From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/8] package/uclibc: use the generic help rules
Date: Thu, 10 Mar 2016 00:47:36 +0100 [thread overview]
Message-ID: <56E0B618.6090107@mind.be> (raw)
In-Reply-To: <39c7d814fe2e6bc45b786d87529a80b3666ac7b0.1457561521.git.yann.morin.1998@free.fr>
On 03/09/16 23:22, Yann E. MORIN wrote:
> Note that the uclibc-menuconfig rule was guarded behind
> BR2_TOOLCHAIN_BUILDROOT, which is wrong ince we can build glibc or musl
> toolchains too...
>
> This is de facto fixed by moving the help text to the uClibc package.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: J?r?me Pouiller <jezz@sysmic.org>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> Makefile | 3 ---
> package/uclibc/uclibc.mk | 2 ++
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index cdf2dac..8973921 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -933,9 +933,6 @@ help:
> @echo ' <pkg>-reconfigure - Restart the build from the configure step'
> @echo ' <pkg>-rebuild - Restart the build from the build step'
> @$(call HELP_RULE,$(PACKAGE_HELP))
> -ifeq ($(BR2_TOOLCHAIN_BUILDROOT),y)
> - @echo ' uclibc-menuconfig - Run uClibc menuconfig'
> -endif
> ifeq ($(BR2_TARGET_BAREBOX),y)
> @echo ' barebox-menuconfig - Run barebox menuconfig'
> @echo ' barebox-savedefconfig - Run barebox savedefconfig'
> diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
> index 200de04..c685828 100644
> --- a/package/uclibc/uclibc.mk
> +++ b/package/uclibc/uclibc.mk
> @@ -11,6 +11,8 @@ UCLIBC_LICENSE = LGPLv2.1+
> UCLIBC_LICENSE_FILES = COPYING.LIB
> UCLIBC_INSTALL_STAGING = YES
>
> +UCLIBC_HELP = "uclibc-menuconfig : Run uClibc menuconfig"
> +
> # uclibc is part of the toolchain so disable the toolchain dependency
> UCLIBC_ADD_TOOLCHAIN_DEPENDENCY = NO
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-03-09 23:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 22:22 [Buildroot] [PATCH 0/8] core: allow for custom, local help; rearrange package-specific help (branch yem/help) Yann E. MORIN
2016-03-09 22:22 ` [Buildroot] [PATCH 1/8] core: add the possibility to provide help for local, custom rules Yann E. MORIN
2016-03-09 23:35 ` Arnout Vandecappelle
2016-03-10 20:22 ` Yann E. MORIN
2016-03-11 0:01 ` Arnout Vandecappelle
2016-03-09 22:22 ` [Buildroot] [PATCH 2/8] core/pkg-utils: add a macro to pretty-print a help entry Yann E. MORIN
2016-03-09 23:37 ` Arnout Vandecappelle
2016-03-10 9:31 ` Jérôme Pouiller
2016-03-10 20:27 ` Yann E. MORIN
2016-03-10 20:24 ` Yann E. MORIN
2016-03-09 22:22 ` [Buildroot] [PATCH 3/8] core/pkg-generic: add help about package-specific rules Yann E. MORIN
2016-03-09 23:38 ` Arnout Vandecappelle
2016-03-09 22:22 ` [Buildroot] [PATCH 4/8] package/busybox: use the generic help rules Yann E. MORIN
2016-03-09 23:38 ` Arnout Vandecappelle
2016-03-09 22:22 ` [Buildroot] [PATCH 5/8] linux: add " Yann E. MORIN
2016-03-09 23:47 ` Arnout Vandecappelle
2016-03-10 9:21 ` Jérôme Pouiller
2016-03-10 9:39 ` Thomas Petazzoni
2016-03-10 9:52 ` Arnout Vandecappelle
2016-03-10 10:12 ` Thomas Petazzoni
2016-03-10 20:34 ` Yann E. MORIN
2016-03-10 20:58 ` Thomas Petazzoni
2016-03-10 20:29 ` Yann E. MORIN
2016-03-09 22:22 ` [Buildroot] [PATCH 6/8] package/uclibc: use " Yann E. MORIN
2016-03-09 23:47 ` Arnout Vandecappelle [this message]
2016-03-09 22:22 ` [Buildroot] [PATCH 7/8] boot/barebox: " Yann E. MORIN
2016-03-09 23:47 ` Arnout Vandecappelle
2016-03-09 22:22 ` [Buildroot] [PATCH 8/8] docs/manual: document the br2-external help-local Yann E. MORIN
2016-03-09 23:35 ` [Buildroot] [PATCH 0/8] core: allow for custom, local help; rearrange package-specific help (branch yem/help) Arnout Vandecappelle
2016-03-10 8:31 ` Thomas Petazzoni
2016-03-10 20:20 ` Yann E. MORIN
2016-03-10 21:01 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E0B618.6090107@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.