From: Fiona <xufeifei@linux.vnet.ibm.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org, chandan@linux.vnet.ibm.com
Subject: Re: [PATCH] btrfs-progs: Replace hardcoded PAGE_CACHE_SIZE with getpagesize().
Date: Thu, 10 Mar 2016 14:06:27 +0800 [thread overview]
Message-ID: <56E10EE3.80803@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160309124524.GB738@twin.jikos.cz>
On 2016/3/9 20:45, David Sterba wrote:
> On Wed, Mar 09, 2016 at 08:22:13PM +0800, Feifei Xu wrote:
>> PAGE_CACHE_SIZE is hardcoded to 4K in cmds-restore.c. It makes lzo
>> decompress fail on ppc64. Fix this through replacing hardcoded 4K
>> with getpagesize().
> You're right that the hardcoded value is a bug, but the correct value is
> the sector size. Ie. when the system is 4k page size and filesystem is
> eg. from ppc64.
Hi David,
You're right, I am working to fix it.
Thanks
Fiona
prev parent reply other threads:[~2016-03-10 6:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 12:22 [PATCH] btrfs-progs: Replace hardcoded PAGE_CACHE_SIZE with getpagesize() Feifei Xu
2016-03-09 12:45 ` David Sterba
2016-03-10 6:06 ` Fiona [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E10EE3.80803@linux.vnet.ibm.com \
--to=xufeifei@linux.vnet.ibm.com \
--cc=chandan@linux.vnet.ibm.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.