From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [RFC 10/35] eal: introduce RTE_DECONST macro
Date: Thu, 10 Mar 2016 09:29:03 +0100
Message-ID: <56E1304F.1000808@6wind.com>
References: <1457540381-20274-1-git-send-email-olivier.matz@6wind.com>
 <1457540381-20274-11-git-send-email-olivier.matz@6wind.com>
 <CAOaVG17eXh8B7kPvtWsH6q6q1E0S0kgT+fhAz_6C3k0=5iM40g@mail.gmail.com>
 <56E08BE7.6030906@6wind.com> <20160309212232.GB8020@bricha3-MOBL3>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id E85492BC9
 for <dev@dpdk.org>; Thu, 10 Mar 2016 09:29:11 +0100 (CET)
In-Reply-To: <20160309212232.GB8020@bricha3-MOBL3>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

>> If you have a better alternative, without duplicating the code,
>> I'll be happy to learn.
> 
> I really don't like this dropping of const either, but I do see the problem.
> I'd nearly rather see two copies of the function than start dropping the const
> in such a way.

I don't think duplicating the code is a good option.

> Also, I'd see having the function itself be a wrapper around a
> macro as a better alternative too, assuming such a construction is possible.

Sorry, I'm not sure to understand. Could you please elaborate?


Regards,
Olivier