From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH, v2] mempool: avoid memory waste with large pagesize Date: Thu, 10 Mar 2016 12:12:12 +0100 Message-ID: <56E1568C.5020805@6wind.com> References: <1457557926-4056-1-git-send-email-stephen@networkplumber.org> <56E1325C.2030206@6wind.com> <56E150FD.2090403@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Ferruh Yigit , Stephen Hemminger , dev@dpdk.org Return-path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 8A1832C55 for ; Thu, 10 Mar 2016 12:12:19 +0100 (CET) In-Reply-To: <56E150FD.2090403@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >> It still does not work. When CONFIG_RTE_LIBRTE_MEMPOOL_DEBUG=y: >> >> mp = rte_mempool_create("test", 128, >> 64, 0, 0, NULL, NULL, NULL, NULL, SOCKET_ID_ANY, 0); >> rte_mempool_dump(stdout, mp); >> >> populated_size=128 >> header_size=64 >> elt_size=64 >> trailer_size=64 >> total_obj_size=192 >> > With --no-huge (since patch updates that part), it gives: > header_size=64 > elt_size=64 > trailer_size=0 > total_obj_size=128 > private_data_size=3904 > > 1- private_data still rounds to page size, not sure if this is a problem. > 2- with MEMPOOL_DEBUG=y, trailer_size is 0, comment in code says it > should keep cookie, not sure if this is a problem. Yes the trailer should at least be 8 bytes to store the cookie.