Re: [Qemu-devel] [PATCH v4 2/5] icount: remove obsolete warp call

[Paolo Bonzini <pbonzini@redhat.com>]

On 10/03/2016 12:56, Pavel Dovgalyuk wrote:
> qemu_clock_warp call in qemu_tcg_wait_io_event function is not needed
> anymore, because it is called in every iteration of main_loop_wait.
> 
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>

Thanks again.  These two patches make the icount mechanism much easier
to understand.

Paolo

> ---
>  cpus.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/cpus.c b/cpus.c
> index bc774e2..85d0f87 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -995,9 +995,6 @@ static void qemu_wait_io_event_common(CPUState *cpu)
>  static void qemu_tcg_wait_io_event(CPUState *cpu)
>  {
>      while (all_cpu_threads_idle()) {
> -       /* Start accounting real time to the virtual clock if the CPUs
> -          are idle.  */
> -        qemu_clock_warp(QEMU_CLOCK_VIRTUAL);
>          qemu_cond_wait(cpu->halt_cond, &qemu_global_mutex);
>      }
>  
>