Re: [PATCH 5/8] drivers/net/ixgbe: Fix vlan filter missing brackets

[Panu Matilainen <pmatilai@redhat.com>]

On 02/25/2016 08:48 PM, Aaron Conole wrote:
> The ixgbe vlan filter code has an if check with an incorrect whitespace.
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
>   drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 3e6fe86..2e1c3ad 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -4258,10 +4258,11 @@ ixgbe_set_pool_vlan_filter(struct rte_eth_dev *dev, uint16_t vlan,
>   	if (ixgbe_vmdq_mode_check(hw) < 0)
>   		return -ENOTSUP;
>   	for (pool_idx = 0; pool_idx < ETH_64_POOLS; pool_idx++) {
> -		if (pool_mask & ((uint64_t)(1ULL << pool_idx)))
> +		if (pool_mask & ((uint64_t)(1ULL << pool_idx))) {
>   			ret = hw->mac.ops.set_vfta(hw,vlan,pool_idx,vlan_on);
>   			if (ret < 0)
>   				return ret;
> +		}
>   	}
>
>   	return ret;
>

Acked-by: Panu Matilainen <pmatilai@redhat.com>

Seems really obvious but cc'd the ixgbe maintainers too.

	- Panu -