From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH 7/8] drivers/net/ixgbe: Signed left shift operator Date: Thu, 10 Mar 2016 15:30:43 +0200 Message-ID: <56E17703.9090109@redhat.com> References: <1456426121-21423-1-git-send-email-aconole@redhat.com> <1456426121-21423-8-git-send-email-aconole@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Aaron Conole , dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 872812BA2 for ; Thu, 10 Mar 2016 14:30:45 +0100 (CET) In-Reply-To: <1456426121-21423-8-git-send-email-aconole@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/25/2016 08:48 PM, Aaron Conole wrote: > Tell the compiler to use an unsigned constant for the config shifts. > > Signed-off-by: Aaron Conole > --- > drivers/net/ixgbe/ixgbe_pf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c > index 2ffbd1f..8b5119f 100644 > --- a/drivers/net/ixgbe/ixgbe_pf.c > +++ b/drivers/net/ixgbe/ixgbe_pf.c > @@ -236,9 +236,9 @@ int ixgbe_pf_host_configure(struct rte_eth_dev *eth_dev) > vfre_slot = (vf_num >> VFRE_SHIFT) > 0 ? 1 : 0; > > /* Enable pools reserved to PF only */ > - IXGBE_WRITE_REG(hw, IXGBE_VFRE(vfre_slot), (~0) << vfre_offset); > + IXGBE_WRITE_REG(hw, IXGBE_VFRE(vfre_slot), (~0U) << vfre_offset); > IXGBE_WRITE_REG(hw, IXGBE_VFRE(vfre_slot ^ 1), vfre_slot - 1); > - IXGBE_WRITE_REG(hw, IXGBE_VFTE(vfre_slot), (~0) << vfre_offset); > + IXGBE_WRITE_REG(hw, IXGBE_VFTE(vfre_slot), (~0U) << vfre_offset); > IXGBE_WRITE_REG(hw, IXGBE_VFTE(vfre_slot ^ 1), vfre_slot - 1); > > /* PFDMA Tx General Switch Control Enables VMDQ loopback */ > Acked-by: Panu Matilainen CC'd the ixgbe maintainers... - Panu -