From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [RFC PATCH 2/2] KVM: MMU: return page fault error code from permission_fault Date: Thu, 10 Mar 2016 22:03:55 +0800 Message-ID: <56E17ECB.1000107@linux.intel.com> References: <1457437538-65867-1-git-send-email-pbonzini@redhat.com> <1457437538-65867-3-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: huaitong.han@intel.com To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Return-path: Received: from mga03.intel.com ([134.134.136.65]:57649 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbcCJOEY (ORCPT ); Thu, 10 Mar 2016 09:04:24 -0500 In-Reply-To: <1457437538-65867-3-git-send-email-pbonzini@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/08/2016 07:45 PM, Paolo Bonzini wrote: > Intel's new PKU extension introduces a bit of the page fault error code > that must be dynamically computed after the PTE lookup (unlike I/D, U/S > and W/R). To ease this, these two patches make permission_fault return > the page fault error code. > > Right now it only adds the P bit to the input parameter "pfec", but PKU > can change that. Yep, i got the same idea when i reviewed the pkey patchset. This patch looks good to me. Reviewed-by: Xiao Guangrong