From mboxrd@z Thu Jan 1 00:00:00 1970 From: Panu Matilainen Subject: Re: [PATCH 8/8] drivers/net/ixgbe: Fix uninitialized warning Date: Thu, 10 Mar 2016 17:03:01 +0200 Message-ID: <56E18CA5.4090200@redhat.com> References: <1456426121-21423-1-git-send-email-aconole@redhat.com> <1456426121-21423-9-git-send-email-aconole@redhat.com> <56E179E2.1020704@redhat.com> <56E18894.6020409@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Remy Horton , dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CE9912BA9 for ; Thu, 10 Mar 2016 16:03:03 +0100 (CET) In-Reply-To: <56E18894.6020409@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/10/2016 04:45 PM, Remy Horton wrote: > > On 10/03/2016 13:42, Panu Matilainen wrote: >> On 02/25/2016 08:48 PM, Aaron Conole wrote: >>> Silence a compiler warning that this variable may be used uninitialized. >>> >>> Signed-off-by: Aaron Conole > [..] >> >> The patch looks ok as such, but then again warning looks like a false >> positive to me: assignment and dereferencing depend on the same value of >> eop, which cannot change between the two. > > In two minds about this. It is a logical impossibility, but these days > optimising compilers are getting very aggressive. For instance GCC has a > delightfully-named -fdelete-null-pointer-checks option, which caused > security holes.. Indeed, that's why silencing a false positive (assuming it actually is one) by throwing some more NULL-checks for the allegedly impossible makes me a bit nervous. Besides compiler optimizations going crazy, I've seen such extra NULL-checks turn into actual bugs when surroundings subtly change. - Panu -