From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH 1/2] libxl: ensure var is inited in libxl__domain_firmware Date: Thu, 10 Mar 2016 09:13:06 -0600 Message-ID: <56E18F02.9050506@cardoe.com> References: <1457403820-2949-1-git-send-email-cardoe@cardoe.com> <20160308153851.GG31271@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2734686998316773692==" Return-path: In-Reply-To: <20160308153851.GG31271@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2734686998316773692== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2Ues1bAUnd9bRlwoA4xWVGU2QDicmqUD5" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2Ues1bAUnd9bRlwoA4xWVGU2QDicmqUD5 Content-Type: multipart/mixed; boundary="UfiG1nQetKSnvT92q0g2qa5B38hMoABgq" From: Doug Goldstein To: Wei Liu Cc: xen-devel@lists.xen.org, Ian Jackson , Stefano Stabellini Message-ID: <56E18F02.9050506@cardoe.com> Subject: Re: [PATCH 1/2] libxl: ensure var is inited in libxl__domain_firmware References: <1457403820-2949-1-git-send-email-cardoe@cardoe.com> <20160308153851.GG31271@citrix.com> In-Reply-To: <20160308153851.GG31271@citrix.com> --UfiG1nQetKSnvT92q0g2qa5B38hMoABgq Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/8/16 9:38 AM, Wei Liu wrote: > On Mon, Mar 07, 2016 at 08:23:39PM -0600, Doug Goldstein wrote: >> Some versions of GCC complain that the 'firmware' variable can be used= >> uninitialized. It looks like the switch inside of the else case is jus= t >> confusing GCC. >> >> Signed-off-by: Doug Goldstein >=20 > Acked-by: Wei Liu >=20 I sent these two together but they really aren't dependent on each other so this can go in without the other. --=20 Doug Goldstein --UfiG1nQetKSnvT92q0g2qa5B38hMoABgq-- --2Ues1bAUnd9bRlwoA4xWVGU2QDicmqUD5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJW4Y8EXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUE9YP/RYQEUNKuLczc55LCjBVTa95 ff2n9f8pQFGjHB53CIXCF5dp3UXD4KCDCfMR+I4OgEIoG/6FeokvTkAqdnDCH5wa fueI5cIJk1+f675tNYOQ7YsQX2zMiOiOrg7x+15XCnaUWsn1iHSmp65AJuhTm8G8 yaFoYIPbXHvEYvfR7NpjNS9WN73kMExRfA7sy4+Y+hsgjZGCCcBscyDkHSIz4usJ 8Konf04+7+E63zVeyDYPJmQwWmxBoebh18eVF/rmpFUBOF3wlJbgMxVGpiyKZVKV nJRSzhSwxKVx+1gTF2xEhAitWA/4H/nKLxsGXRJzUL90VoM8vV72fWL/wxY9T9PL 3fAsa5zs2Snor9e2+WWWgp2OToS2r+C0B5xBa0ErKiCZezLwxj0md1mPh/flmqd3 ajL6e2Xn/AhXHIkB/I0PsLUe1wGIoj18tPHbPyiHzuDv5tpFpBuqL/uAU4nAMt5L CspREsMpE2mgGfYTNor2boQK4H2r1L48EojiNQ6GSESXdsdDU35D7BTdBqozN6ja HO1rRRt6OJpyobTgkYV38z6JZjRfj1Dyq0SfZcYZJsC9PE0Dpyd5Re7mbdWpo5QM 4upDC+qoBWLo+VpTUYkpTlIuSE9WbI0Y6FKt0fPhgM7jtSR2v1mjHobJi7WEPvH5 5ZsEqvUqsQywZqOexSK8 =8NXy -----END PGP SIGNATURE----- --2Ues1bAUnd9bRlwoA4xWVGU2QDicmqUD5-- --===============2734686998316773692== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============2734686998316773692==--