From: Samuel Pitoiset <samuel.pitoiset@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>, Ilia Mirkin <imirkin@alum.mit.edu>
Cc: mesa-dev@lists.freedesktop.org, nouveau@lists.freedesktop.org
Subject: Re: [PATCH mesa 1/3] tgsi: Fix decl.Atomic and .Shared not propagating when parsing tgsi text
Date: Thu, 10 Mar 2016 16:25:34 +0100 [thread overview]
Message-ID: <56E191EE.5020805@gmail.com> (raw)
In-Reply-To: <1457622887-19328-2-git-send-email-hdegoede@redhat.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
On 03/10/2016 04:14 PM, Hans de Goede wrote:
> When support for decl.Atomic and .Shared was added, tgsi_build_declaration
> was not updated to propagate these properly.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> src/gallium/auxiliary/tgsi/tgsi_build.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_build.c b/src/gallium/auxiliary/tgsi/tgsi_build.c
> index cfe9b92..c420ae1 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_build.c
> +++ b/src/gallium/auxiliary/tgsi/tgsi_build.c
> @@ -127,6 +127,8 @@ tgsi_build_declaration(
> unsigned invariant,
> unsigned local,
> unsigned array,
> + unsigned atomic,
> + unsigned shared,
> struct tgsi_header *header )
> {
> struct tgsi_declaration declaration;
> @@ -143,6 +145,8 @@ tgsi_build_declaration(
> declaration.Invariant = invariant;
> declaration.Local = local;
> declaration.Array = array;
> + declaration.Atomic = atomic;
> + declaration.Shared = shared;
> header_bodysize_grow( header );
>
> return declaration;
> @@ -401,6 +405,8 @@ tgsi_build_full_declaration(
> full_decl->Declaration.Invariant,
> full_decl->Declaration.Local,
> full_decl->Declaration.Array,
> + full_decl->Declaration.Atomic,
> + full_decl->Declaration.Shared,
> header );
>
> if (maxsize <= size)
>
--
-Samuel
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
next prev parent reply other threads:[~2016-03-10 15:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 15:14 [PATCH mesa 0/3] tgsi and nouveau global / local / opencl-input mem support Hans de Goede
[not found] ` <1457622887-19328-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-10 15:14 ` [PATCH mesa 1/3] tgsi: Fix decl.Atomic and .Shared not propagating when parsing tgsi text Hans de Goede
[not found] ` <1457622887-19328-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-10 15:24 ` Ilia Mirkin
2016-03-10 15:25 ` Samuel Pitoiset [this message]
2016-03-10 15:14 ` [PATCH mesa 2/3] tgsi: Add support for global / local / input MEMORY Hans de Goede
[not found] ` <1457622887-19328-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-10 15:28 ` Ilia Mirkin
2016-03-10 15:35 ` Aaron Watry
2016-03-10 18:43 ` Hans de Goede
2016-03-10 15:14 ` [PATCH mesa 3/3] nouveau: Add support for clover / OpenCL kernel input parameters Hans de Goede
2016-03-10 15:23 ` Ilia Mirkin
2016-03-10 15:27 ` Samuel Pitoiset
[not found] ` <56E19271.7070704-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-10 15:43 ` Ilia Mirkin
2016-03-10 15:46 ` Samuel Pitoiset
[not found] ` <CAKb7UvhrroOY2ShG_XcoPB+TRF2NpLAmV+QWdw88B3o1Unhe0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-10 16:03 ` Samuel Pitoiset
[not found] ` <56E19AEB.3060606-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-10 17:54 ` Hans de Goede
2016-03-10 16:03 ` [Nouveau] " Pierre Moreau
2016-03-10 16:05 ` Ilia Mirkin
2016-03-10 16:13 ` Pierre Moreau
2016-03-10 16:05 ` Samuel Pitoiset
[not found] ` <56E19B67.3030306-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-10 16:06 ` Ilia Mirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E191EE.5020805@gmail.com \
--to=samuel.pitoiset@gmail.com \
--cc=hdegoede@redhat.com \
--cc=imirkin@alum.mit.edu \
--cc=mesa-dev@lists.freedesktop.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.