From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH] KVM: Remove redundant smp_mb() in the kvm_mmu_commit_zap_page() Date: Thu, 10 Mar 2016 23:45:48 +0800 Message-ID: <56E196AC.4030103@linux.intel.com> References: <1457055312-27067-1-git-send-email-tianyu.lan@intel.com> <56D9354E.9040908@intel.com> <56D94BFE.1080406@redhat.com> <56DE8F1A.9000401@intel.com> <56DEEF69.20208@redhat.com> <56E1875E.8060007@linux.intel.com> <56E19224.9090906@redhat.com> <56E1933E.20909@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: gleb@kernel.org, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Paolo Bonzini , Lan Tianyu , Thomas Gleixner Return-path: Received: from mga03.intel.com ([134.134.136.65]:15036 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbcCJPrs (ORCPT ); Thu, 10 Mar 2016 10:47:48 -0500 In-Reply-To: <56E1933E.20909@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/10/2016 11:31 PM, Paolo Bonzini wrote: > > > On 10/03/2016 16:26, Paolo Bonzini wrote: >> Compared to smp_load_acquire(), smp_mb() adds an ordering between stores >> and loads. > > Here, the ordering is load-store, hence... Yes, this is why i put smp_mb() in the code. :)