From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae3Us-0001K1-Eb for qemu-devel@nongnu.org; Thu, 10 Mar 2016 11:31:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ae3Up-0006oM-OS for qemu-devel@nongnu.org; Thu, 10 Mar 2016 11:31:34 -0500 Received: from resqmta-po-10v.sys.comcast.net ([96.114.154.169]:48183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae3Up-0006nl-Hz for qemu-devel@nongnu.org; Thu, 10 Mar 2016 11:31:31 -0500 References: <1457544504-8548-1-git-send-email-berrange@redhat.com> <1457544504-8548-13-git-send-email-berrange@redhat.com> <56E061B1.9040706@redhat.com> <56E08098.5050403@redhat.com> <56E094A3.5010103@redhat.com> <20160310094155.GD25607@redhat.com> <56E14465.8060607@redhat.com> From: Eric Blake Message-ID: <56E1A11C.8020106@redhat.com> Date: Thu, 10 Mar 2016 09:30:20 -0700 MIME-Version: 1.0 In-Reply-To: <56E14465.8060607@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0jEXQ4EdrE3N74bw6Pj1Lclwsb4vv0j2b" Subject: Re: [Qemu-devel] [PATCH v1 12/21] io: implement socket watch for win32 using WSAEventSelect+select List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , "Daniel P. Berrange" Cc: Stefan Weil , qemu-devel@nongnu.org, Andrew Baumann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0jEXQ4EdrE3N74bw6Pj1Lclwsb4vv0j2b Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/10/2016 02:54 AM, Paolo Bonzini wrote: >=20 >=20 > On 10/03/2016 10:41, Daniel P. Berrange wrote: >>>> >>>> https://github.com/bonzini/qemu/commit/win32-qio-watch^ >> Since I made non-trivial changes to this commit, I thought it was >> corrrect to remove your S-o-b, to avoid claiming that you'd already >> signed off on the changes I made. Was that not the right thing >> todo ? >=20 > You should have then also removed the authorship. I think in this case= > leaving the author and the s-o-b was the right thing to do, followed by= > removing the authorship and leaving the s-o-b. Signed-off-by is more o= f > a legal thing than a "I think that these changes are good for QEMU". I've seen this pattern of keeping original authorship and S-o-b, coupled with an extension to the commit message, in the qemu.git history, something like: original title original message S-o-b: original [make the following additional changes] S-o-b: second author --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --0jEXQ4EdrE3N74bw6Pj1Lclwsb4vv0j2b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW4aEcAAoJEKeha0olJ0Nq8NgH/jmfqRo10GeHN305Ez8TXY89 LzbGxc32JIsdZxTQdWIwZMoW6tz5Ssg4qx0JHHiydgOyHfWxNz9O9qI6G4u7pzSo Vq+qdeyLvkq9T/4OvIIuP9KWKuu70vvsDS3yQ7FnnutZry/CUXT/nIx8TCasbNA4 y+3Nb3Ek2UzZvfeeWReNVZOZCi3tAieAwOyjkL+2SlHf+oEcKTyFOAWb3NPxkulO YRYwAxTtzXbyqM9JGxM7j/IoDFqqaFyabiokAgQuN/a7g4FVrQWUp2nr74BnWf/n HkINYQ8+rAuHN3pfr5RLu64tODqtTb+gwosLcUBvk0tqQNa3liHRBN9e9WffB2Q= =cfEJ -----END PGP SIGNATURE----- --0jEXQ4EdrE3N74bw6Pj1Lclwsb4vv0j2b--