All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Schmidt <stefan@osg.samsung.com>
To: Alan Ott <alan@signal11.us>, zopieux <web@zopieux.com>,
	linux-wpan@vger.kernel.org
Cc: netdev@vger.kernel.org, Alexander Aring <alex.aring@gmail.com>
Subject: Re: [PATCH] mrf24j40: fix security-enabled processing on inbound frames
Date: Thu, 10 Mar 2016 17:40:47 +0100	[thread overview]
Message-ID: <56E1A38F.6050108@osg.samsung.com> (raw)
In-Reply-To: <56D4A0C2.5090605@signal11.us>

Hello.

On 29/02/16 20:49, Alan Ott wrote:
> On 02/18/2016 01:34 PM, zopieux wrote:
>> Fix the MRF24J40 handling of security-enabled frames so it does not
>> block upon receiving such frames.
>>
>> Signed-off-by: Alexander Aring <aar@pengutronix.de>
>> Reported-by: Alexandre Macabies <web+oss@zopieux.com>
>> Tested-by: Alexandre Macabies <web+oss@zopieux.com>
>> ---
>> When receiving a security-enabled IEEE 802.15.4 frame, the MRF24J40
>> triggers a SECIF interrupt that needs to be handled for RX processing
>> to keep functioning properly.
>>
>> This patch enables the SECIF interrupt and makes the MRF ignores all
>> hardware processing of security-enabled frames, that is handled by the
>> ieee802154 stack instead.
>> ---
>
> The "From" field of the email needs to have your real name in it. This 
> will be where the "Author" field in git comes from.
>
> It looks like there are a few separate things happening in this patch. 
> Maybe they should be broken out in to separate patches. I see:
>
> 1. The ieee802154.h part,
> 2. The TX part,
> 3. The RX part.
>
> The patch description only really describes the RX part.
>

zopieux, could you split the patch as Alan suggested and re-submitted 
the series?

regards
Stefan Schmidt

      reply	other threads:[~2016-03-10 16:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 18:34 [PATCH] mrf24j40: fix security-enabled processing on inbound frames zopieux
2016-02-23  9:29 ` Alexander Aring
2016-02-29 18:46   ` Alan Ott
2016-02-29 19:49 ` Alan Ott
2016-03-10 16:40   ` Stefan Schmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E1A38F.6050108@osg.samsung.com \
    --to=stefan@osg.samsung.com \
    --cc=alan@signal11.us \
    --cc=alex.aring@gmail.com \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=web@zopieux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.