From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae4Mh-0001qY-FT for qemu-devel@nongnu.org; Thu, 10 Mar 2016 12:27:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ae4Mc-0001OP-4f for qemu-devel@nongnu.org; Thu, 10 Mar 2016 12:27:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ae4Mb-0001OC-VM for qemu-devel@nongnu.org; Thu, 10 Mar 2016 12:27:06 -0500 References: <1457600259-2662-1-git-send-email-jitendra.kolhe@hpe.com> From: Eric Blake Message-ID: <56E1AE67.4040708@redhat.com> Date: Thu, 10 Mar 2016 10:27:03 -0700 MIME-Version: 1.0 In-Reply-To: <1457600259-2662-1-git-send-email-jitendra.kolhe@hpe.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="urqjqJ8wG0Ki0bODkj3RoCihPCfL3lxRg" Subject: Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jitendra Kolhe Cc: simhan@hpe.com, mohan_parthasarathy@hpe.com, qemu-devel@nongnu.org, dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --urqjqJ8wG0Ki0bODkj3RoCihPCfL3lxRg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/10/2016 01:57 AM, Jitendra Kolhe wrote: >>> +++ b/qapi-schema.json >>> @@ -544,11 +544,14 @@ >>> # been migrated, pulling the remaining pages along as neede= d. NOTE: If >>> # the migration fails during postcopy the VM will fail. (s= ince 2.5) >>> # >>> +# @skip-balloon: Skip scaning ram pages released by virtio-balloon d= river. >> >> s/scaning/scanning/ >> >>> +# (since 2.5) >> >> You've missed 2.5. In fact, this is borderline between new feature an= d >> bug fix, so you may have even missed 2.6 since soft freeze has already= >> passed, in which case this should read 2.7. >=20 > Thanks for sharing the timeline was not aware of it. I think making cha= nges to=20 > version 2.7 should be fine. However the version string "(since 2.5)" is= > part of existing code. I have added a new option "skip-balloon" below i= t. MigrationCapability is since 1.2, x-postcopy-ram is since 2.5, and your addition of skip-balloon is since 2.7. In other words, when you copy-pasted x-postcopy-ram's "(since 2.5)" as your starting point for writing the docs for your new skip-balloon, you need to update the version in which your new capability is actually exposed. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --urqjqJ8wG0Ki0bODkj3RoCihPCfL3lxRg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW4a5nAAoJEKeha0olJ0Nql7AIAKAnMUH/Lmt3IKFrYj12T8OW ozzqZGPK+TJjwV+SNBrAwP/DiwLIXdS7MGWwMQzRIRkHVDMgicQQwrnT5l1GKQVt ga+UsS4xYI5mHsPlHd1/v0HznVgVAEE0zmshsCeIMcqXTrGkOlaC6JfXxdrrhPz7 ny1oxkH9RTlmaXWge5lPclIwaf2FVOqC7BFONO93KDkKkAM+oLHV+fvT+U0ozcF8 TVbva3zwNWbEsv2t2kNTi02Rk5qMb/R65Mi7uHuzs+1cH2YV6RDKuaZzy7GEFLcC zY3wPR0OllrSy0HqyXetum8U8nkd00Qw0NeIDBnKdKyEfofbb9ugmR2hvso4wUE= =vQgE -----END PGP SIGNATURE----- --urqjqJ8wG0Ki0bODkj3RoCihPCfL3lxRg--