From: Tomas Henzl <thenzl@redhat.com>
To: Sumit Saxena <sumit.saxena@broadcom.com>,
jbottomley@parallels.com, martin.petersen@oracle.com,
hch@infradead.org
Cc: linux-scsi@vger.kernel.org, kashyap.desai@broadcom.com
Subject: Re: [PATCH] megaraid_sas: Don't issue kill adapter for MFI controllers in case of PD list DCMD failure
Date: Thu, 10 Mar 2016 22:35:26 +0100 [thread overview]
Message-ID: <56E1E89E.5000306@redhat.com> (raw)
In-Reply-To: <1457604877-5280-1-git-send-email-sumit.saxena@broadcom.com>
On 10.3.2016 11:14, Sumit Saxena wrote:
> There are few MFI adapters which do not support MR_DCMD_PD_LIST_QUERY so
> if MFI adapters fail this DCMD, it should not be considered as FATAL and
> driver should not issue kill adapter and set per controller's instance
> variable- pd_list_not_supported so that same variable can be used inside
> functions- slave_alloc and slave_configure to allow firmware scan.
>
> Killing adapter because of DCMD failure when this DCMD is not supported
> causes driver's probe getting failed. This issue got introduced because
> of below commit when MFI IO timeout handling was introduced-
>
> 6d40afb megaraid_sas: MFI IO timeout handling
>
> Killing adapter in case of this DCMD failure should be limited to Fusion
> adapters only. Per controller's instance variable allow_fw_scan is removed
> as pd_list_not_supported better reflect the purpose.
>
> Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
next prev parent reply other threads:[~2016-03-10 21:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 10:14 [PATCH] megaraid_sas: Don't issue kill adapter for MFI controllers in case of PD list DCMD failure Sumit Saxena
2016-03-10 10:40 ` Johannes Thumshirn
2016-03-10 13:06 ` Hannes Reinecke
2016-03-10 15:28 ` Ewan Milne
2016-03-10 21:35 ` Tomas Henzl [this message]
2016-03-11 1:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E1E89E.5000306@redhat.com \
--to=thenzl@redhat.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.