From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeCgx-00072n-LS for qemu-devel@nongnu.org; Thu, 10 Mar 2016 21:20:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeCgu-0006Op-FD for qemu-devel@nongnu.org; Thu, 10 Mar 2016 21:20:39 -0500 Received: from g1t6220.austin.hp.com ([15.73.96.84]:34173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeCgu-0006Oa-9x for qemu-devel@nongnu.org; Thu, 10 Mar 2016 21:20:36 -0500 References: <1457600259-2662-1-git-send-email-jitendra.kolhe@hpe.com> <56E1AE67.4040708@redhat.com> From: Jitendra Kolhe Message-ID: <56E22B6F.6080206@hpe.com> Date: Fri, 11 Mar 2016 07:50:31 +0530 MIME-Version: 1.0 In-Reply-To: <56E1AE67.4040708@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: simhan@hpe.com, mohan_parthasarathy@hpe.com, qemu-devel@nongnu.org, dgilbert@redhat.com On 3/10/2016 10:57 PM, Eric Blake wrote: > On 03/10/2016 01:57 AM, Jitendra Kolhe wrote: > >>>> +++ b/qapi-schema.json >>>> @@ -544,11 +544,14 @@ >>>> # been migrated, pulling the remaining pages along as needed. NOTE: If >>>> # the migration fails during postcopy the VM will fail. (since 2.5) >>>> # >>>> +# @skip-balloon: Skip scaning ram pages released by virtio-balloon driver. >>> >>> s/scaning/scanning/ >>> >>>> +# (since 2.5) >>> >>> You've missed 2.5. In fact, this is borderline between new feature and >>> bug fix, so you may have even missed 2.6 since soft freeze has already >>> passed, in which case this should read 2.7. >> >> Thanks for sharing the timeline was not aware of it. I think making changes to >> version 2.7 should be fine. However the version string "(since 2.5)" is >> part of existing code. I have added a new option "skip-balloon" below it. > > MigrationCapability is since 1.2, x-postcopy-ram is since 2.5, and your > addition of skip-balloon is since 2.7. In other words, when you > copy-pasted x-postcopy-ram's "(since 2.5)" as your starting point for > writing the docs for your new skip-balloon, you need to update the > version in which your new capability is actually exposed. > My apologies, I didn't realize my patch too was adding version string. Will update to version string to 2.7. - Jitendra