From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic Date: Fri, 11 Mar 2016 14:09:00 +0100 Message-ID: <56E2C36C.6030709@samsung.com> References: <1457122813-12791-1-git-send-email-javier@osg.samsung.com> <56DD48C1.8010004@samsung.com> <56DD9086.7070903@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <56DD9086.7070903@osg.samsung.com> Sender: linux-media-owner@vger.kernel.org To: Javier Martinez Canillas Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Kukjin Kim , Mauro Carvalho Chehab , linux-samsung-soc@vger.kernel.org, Kyungmin Park , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote: > Thanks, I just noticed another similar issue in the driver now and is > that fimc_is_parse_sensor_config() uses the same struct device_node * > for looking up the I2C sensor, port and endpoint and thus not doing a > of_node_put() for all the nodes on the error path. > > I think the right fix is to have a separate struct device_node * for > each so their reference counter can be incremented and decremented. Yes, the node reference count is indeed not handled very well there, feel free to submit a patch to fix that bug. -- Regards, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.nawrocki@samsung.com (Sylwester Nawrocki) Date: Fri, 11 Mar 2016 14:09:00 +0100 Subject: [PATCH 0/2] [media] exynos4-is: Trivial fixes for DT port/endpoint parse logic In-Reply-To: <56DD9086.7070903@osg.samsung.com> References: <1457122813-12791-1-git-send-email-javier@osg.samsung.com> <56DD48C1.8010004@samsung.com> <56DD9086.7070903@osg.samsung.com> Message-ID: <56E2C36C.6030709@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/07/2016 03:30 PM, Javier Martinez Canillas wrote: > Thanks, I just noticed another similar issue in the driver now and is > that fimc_is_parse_sensor_config() uses the same struct device_node * > for looking up the I2C sensor, port and endpoint and thus not doing a > of_node_put() for all the nodes on the error path. > > I think the right fix is to have a separate struct device_node * for > each so their reference counter can be incremented and decremented. Yes, the node reference count is indeed not handled very well there, feel free to submit a patch to fix that bug. -- Regards, Sylwester