From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aeNZ0-0006TS-Qr for qemu-devel@nongnu.org; Fri, 11 Mar 2016 08:57:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aeNYz-0001IU-QA for qemu-devel@nongnu.org; Fri, 11 Mar 2016 08:57:10 -0500 References: <1457412306-18940-1-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <56E2CEAC.3090407@redhat.com> Date: Fri, 11 Mar 2016 14:57:00 +0100 MIME-Version: 1.0 In-Reply-To: <1457412306-18940-1-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EjlBsJHJCRUSl4wsRinGhjVQo1imFcNQl" Subject: Re: [Qemu-devel] [PATCH v4 00/15] Dirty bitmap changes for migration/persistence work List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Vladimir Sementsov-Ogievskiy , jsnow@redhat.com, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EjlBsJHJCRUSl4wsRinGhjVQo1imFcNQl Content-Type: multipart/mixed; boundary="0EfSd1V4LPnUCdaM1GlMpCHRRQa7sQCvH" From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Vladimir Sementsov-Ogievskiy , jsnow@redhat.com, kwolf@redhat.com Message-ID: <56E2CEAC.3090407@redhat.com> Subject: Re: [PATCH v4 00/15] Dirty bitmap changes for migration/persistence work References: <1457412306-18940-1-git-send-email-famz@redhat.com> In-Reply-To: <1457412306-18940-1-git-send-email-famz@redhat.com> --0EfSd1V4LPnUCdaM1GlMpCHRRQa7sQCvH Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 08.03.2016 05:44, Fam Zheng wrote: > v4: Rebase. > Add rev-by from John in patches 1-5, 7, 8. > Remove BdrvDirtyBitmap typedef from dirty-bitmap.h in patch 4. [Max= ] > Add assertion on bm->meta in patch 9. [John] >=20 > Two major features are added to block dirty bitmap (and underlying HBit= map) in > this series: meta bitmap and serialization, together with all other sup= portive > patches. >=20 > Both operations are common in dirty bitmap migration and persistence: t= hey need > to find whether and which part of the dirty bitmap in question has chan= ged with > meta dirty bitmap, and they need to write it to the target with seriali= zation. >=20 >=20 > Fam Zheng (13): > backup: Use Bitmap to replace "s->bitmap" > block: Include hbitmap.h in block.h > typedefs: Add BdrvDirtyBitmap > block: Move block dirty bitmap code to separate files > block: Remove unused typedef of BlockDriverDirtyHandler > block: Hide HBitmap in block dirty bitmap interface > HBitmap: Introduce "meta" bitmap to track bit changes > tests: Add test code for meta bitmap > block: Support meta dirty bitmap > block: Add two dirty bitmap getters > block: Assert that bdrv_release_dirty_bitmap succeeded > tests: Add test code for hbitmap serialization > block: More operations for meta dirty bitmap >=20 > Vladimir Sementsov-Ogievskiy (2): > hbitmap: serialization > block: BdrvDirtyBitmap serialization interface >=20 > block.c | 360 ----------------------------- > block/Makefile.objs | 2 +- > block/backup.c | 25 +- > block/dirty-bitmap.c | 535 +++++++++++++++++++++++++++++++++++= ++++++++ > block/mirror.c | 15 +- > include/block/block.h | 40 +--- > include/block/dirty-bitmap.h | 75 ++++++ > include/qemu/hbitmap.h | 96 ++++++++ > include/qemu/typedefs.h | 2 + > tests/test-hbitmap.c | 255 +++++++++++++++++++++ > util/hbitmap.c | 203 ++++++++++++++-- > 11 files changed, 1177 insertions(+), 431 deletions(-) > create mode 100644 block/dirty-bitmap.c > create mode 100644 include/block/dirty-bitmap.h Thanks, applied patches 1 through 5 to my block tree (because of the large code movement in patch 4): https://github.com/XanClic/qemu/commits/block Max --0EfSd1V4LPnUCdaM1GlMpCHRRQa7sQCvH-- --EjlBsJHJCRUSl4wsRinGhjVQo1imFcNQl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW4s6sAAoJEDuxQgLoOKyt1vkIAIOMO8MZPSuYCOGjQ0Rs1ECw S2QzECCpRp3pRbohC8JlydoIb4HxztFT6/lR9DT3Z1JfGBkRlFoEwSl2VBZd0AZQ Vyg92qwoT7GjlVOVJDLWWSu3xx2mK3UrRNnBQJPAzgq3nyglUqZgCAL2dJhkLieJ H96DN+QUW4TZoz1riD/qnSdfaGtIzOZPCqBAzh7FMNgpCnO3nFvNM8v7RS0ueNGu Uwf8i15KAhStt9iiyaCeTft33AM5JwDxkgJUBhA1wexd7+nj3g5tscVvLhDeGJur IxBzGW3kzHo1c0400tdV370dTXDFFM07+Xgo8QtrDyaaiXf4YLYBtvNcOlVQNcU= =9Fch -----END PGP SIGNATURE----- --EjlBsJHJCRUSl4wsRinGhjVQo1imFcNQl--