From: "Michael Kerrisk (man-pages)" <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: nforro-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] recv.2, cmsg.3: Fix type of cmsg_len member of cmsghdr structure
Date: Fri, 11 Mar 2016 17:33:44 +0100 [thread overview]
Message-ID: <56E2F368.1020301@gmail.com> (raw)
In-Reply-To: <1457690557.5377.2.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Hello Nikola
On 03/11/2016 11:02 AM, Nikola Forró wrote:
> The type shown for cmsg_len member of cmsghdr structure is socklen_t,
> but the actual type used by glibc and the kernel is size_t.
>
> The information was obtained from glibc source code:
> http://bit.ly/21m1RMp
Thanks for the patch. I've applied it. However, the story is a little
more complex, because according to POSIX the type is 'socklen_t'.
So, I added some words in both pages point this out.
Cheers,
Michael
> Signed-off-by: Nikola Forró <nforro-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> man2/recv.2 | 6 +++---
> man3/cmsg.3 | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/man2/recv.2 b/man2/recv.2
> index 33265b8..0491880 100644
> --- a/man2/recv.2
> +++ b/man2/recv.2
> @@ -393,9 +393,9 @@ The messages are of the form:
> .nf
>
> struct cmsghdr {
> - socklen_t cmsg_len; /* data byte count, including hdr */
> - int cmsg_level; /* originating protocol */
> - int cmsg_type; /* protocol-specific type */
> + size_t cmsg_len; /* data byte count, including hdr */
> + int cmsg_level; /* originating protocol */
> + int cmsg_type; /* protocol-specific type */
> /* followed by
> unsigned char cmsg_data[]; */
> };
> diff --git a/man3/cmsg.3 b/man3/cmsg.3
> index f1c4459..f97333f 100644
> --- a/man3/cmsg.3
> +++ b/man3/cmsg.3
> @@ -28,9 +28,9 @@ CMSG_ALIGN, CMSG_SPACE, CMSG_NXTHDR, CMSG_FIRSTHDR \- access ancillary data
> .sp
> .nf
> struct cmsghdr {
> - socklen_t cmsg_len; /* data byte count, including header */
> - int cmsg_level; /* originating protocol */
> - int cmsg_type; /* protocol-specific type */
> + size_t cmsg_len; /* data byte count, including header */
> + int cmsg_level; /* originating protocol */
> + int cmsg_type; /* protocol-specific type */
> /* followed by unsigned char cmsg_data[]; */
> };
> .fi
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-03-11 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 10:02 [patch] recv.2, cmsg.3: Fix type of cmsg_len member of cmsghdr structure Nikola Forró
[not found] ` <1457690557.5377.2.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-11 16:33 ` Michael Kerrisk (man-pages) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E2F368.1020301@gmail.com \
--to=mtk.manpages-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nforro-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.