Re: [PATCH] scsi_transport_sas: add 'scsi_target_id' sysfs attribute

[Manoj Kumar <manoj@linux.vnet.ibm.com>]

On 3/11/2016 9:33 AM, Hannes Reinecke wrote:
> There is no way to detect the scsi_target_id for any given SAS
> remote port, so add a new sysfs attribute 'scsi_target_id'.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
>   drivers/scsi/scsi_sas_internal.h  | 2 +-
>   drivers/scsi/scsi_transport_sas.c | 2 ++
>   2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_sas_internal.h b/drivers/scsi/scsi_sas_internal.h
> index 6266a5d..e659912 100644
> --- a/drivers/scsi/scsi_sas_internal.h
> +++ b/drivers/scsi/scsi_sas_internal.h
> @@ -4,7 +4,7 @@
>   #define SAS_HOST_ATTRS		0
>   #define SAS_PHY_ATTRS		17
>   #define SAS_PORT_ATTRS		1
> -#define SAS_RPORT_ATTRS		7
> +#define SAS_RPORT_ATTRS		8
>   #define SAS_END_DEV_ATTRS	5
>   #define SAS_EXPANDER_ATTRS	7
>
> diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c
> index 80520e2..deb3fde 100644
> --- a/drivers/scsi/scsi_transport_sas.c
> +++ b/drivers/scsi/scsi_transport_sas.c
> @@ -1286,6 +1286,7 @@ sas_rphy_protocol_attr(identify.target_port_protocols, target_port_protocols);
>   sas_rphy_simple_attr(identify.sas_address, sas_address, "0x%016llx\n",
>   		unsigned long long);
>   sas_rphy_simple_attr(identify.phy_identifier, phy_identifier, "%d\n", u8);
> +sas_rphy_simple_attr(scsi_target_id, scsi_target_id, "%d\n", u8);

Hannes:

Shouldn't the last argument be u32?

- Manoj Kumar