From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Zapolskiy <vz@mleia.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
grant.likely@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
frowand.list@gmail.com
Subject: Re: [PATCH 1/2] of_mdio: use IS_ERR_OR_NULL()
Date: Fri, 11 Mar 2016 15:03:31 -0800 [thread overview]
Message-ID: <56E34EC3.2000008@gmail.com> (raw)
In-Reply-To: <56E34C56.10300@mleia.com>
On 11/03/16 14:53, Vladimir Zapolskiy wrote:
> Hello Sergei,
>
> On 12.03.2016 00:12, Sergei Shtylyov wrote:
>> IS_ERR_OR_NULL() is open coded in of_mdiobus_register_{phy|device}(), so
>> just call it directly...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>> drivers/of/of_mdio.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Index: net-next/drivers/of/of_mdio.c
>> ===================================================================
>> --- net-next.orig/drivers/of/of_mdio.c
>> +++ net-next/drivers/of/of_mdio.c
>> @@ -56,7 +56,7 @@ static int of_mdiobus_register_phy(struc
>> phy = phy_device_create(mdio, addr, phy_id, 0, NULL);
>> else
>> phy = get_phy_device(mdio, addr, is_c45);
>> - if (!phy || IS_ERR(phy))
>> + if (IS_ERR_OR_NULL(phy))
>> return 1;
>>
>> rc = irq_of_parse_and_map(child, 0);
>> @@ -98,7 +98,7 @@ static int of_mdiobus_register_device(st
>> int rc;
>>
>> mdiodev = mdio_device_create(mdio, addr);
>> - if (!mdiodev || IS_ERR(mdiodev))
>> + if (IS_ERR_OR_NULL(mdiodev))
>> return 1;
>>
>
> I don't see how it is possible for mdio_device_create() to return NULL,
> instead of this change consider to remove if (!mdiodev) check.
Good point, worst case we return PTR_ERR(-ENOMEM).
--
Florian
next prev parent reply other threads:[~2016-03-11 23:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 22:11 [PATCH 0/2] of_mdio: use IS_ERR_OR_NULL() and PTR_ERR_OR_ZERO() Sergei Shtylyov
2016-03-11 22:12 ` [PATCH 1/2] of_mdio: use IS_ERR_OR_NULL() Sergei Shtylyov
2016-03-11 22:48 ` Florian Fainelli
[not found] ` <3305414.rAFdOb57tB-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-03-11 22:53 ` Vladimir Zapolskiy
2016-03-11 23:03 ` Florian Fainelli [this message]
2016-03-11 22:13 ` [PATCH 2/2] of_mdio: use PTR_ERR_OR_ZERO() Sergei Shtylyov
2016-03-11 22:49 ` Florian Fainelli
2016-03-11 23:02 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E34EC3.2000008@gmail.com \
--to=f.fainelli@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.