From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net ([212.227.17.21]:58763 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbcCLIRR (ORCPT ); Sat, 12 Mar 2016 03:17:17 -0500 Subject: Re: [PATCH v7 01/20] btrfs: dedup: Introduce dedup framework and its header To: dsterba@suse.cz, Qu Wenruo , NeilBrown , linux-btrfs@vger.kernel.org, clm@fb.com, Wang Xiaoguang References: <1455774178-3595-1-git-send-email-quwenruo@cn.fujitsu.com> <1455774178-3595-2-git-send-email-quwenruo@cn.fujitsu.com> <87io0vjq9x.fsf@notabene.neil.brown.name> <56E0C668.4020406@cn.fujitsu.com> <20160311114305.GQ18908@twin.jikos.cz> From: Qu Wenruo Message-ID: <56E3D070.3020005@gmx.com> Date: Sat, 12 Mar 2016 16:16:48 +0800 MIME-Version: 1.0 In-Reply-To: <20160311114305.GQ18908@twin.jikos.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 03/11/2016 07:43 PM, David Sterba wrote: > On Thu, Mar 10, 2016 at 08:57:12AM +0800, Qu Wenruo wrote: >>> The ioctl FIDEDUPERANGE and the tool duperemove both use "dupe". >>> It would be nice if we could be consistent and all use the same >>> abbreviation. >> >> Yes, current kernel VFS level offline dedup uses the name "dedupe". >> But on the other hand, ZFS uses the name "dedup" for their online dedup. >> >> And personally speaking, I'd like some difference to distinguish inline >> dedup and offline dedup. >> In that case, the extra "e" seems somewhat useful. >> With "e", it's intended for offline use. Without "e", it's intended for >> online use. > > Such difference is very subtle and I think we should stick to just one > spelling, which shall be 'dedupe'. OK, I'll change them to 'dedupe' in next bug fix version. Thanks, Qu