All of lore.kernel.org
 help / color / mirror / Atom feed
From: jeremy.linton@arm.com (Jeremy Linton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] arm64: pmu: Add support for probing with ACPI
Date: Sun, 13 Mar 2016 20:44:30 -0500	[thread overview]
Message-ID: <56E6177E.6020702@arm.com> (raw)
In-Reply-To: <56E5F7A6.3030905@codeaurora.org>

On 03/13/2016 06:28 PM, Timur Tabi wrote:
> Jeremy Linton wrote:
>> +    int i, count, irq;
>> +
>> +    if (acpi_disabled)
>> +        return 0;
>> +
>> +    acpi_parse_boot_cpu();
>> +
>> +    /* Must have irq for boot boot cpu, at least */
>> +    if (pirq->gsi == 0)
>> +        return -EINVAL;
>> +
>> +    irq = acpi_register_gsi(NULL, pirq->gsi, pirq->trigger,
>> +                ACPI_ACTIVE_HIGH);
>> +
>> +    if (irq_is_percpu(irq))
>> +        count = 1;
>> +    else
>> +        for (i = 1, count = 1; i < NR_CPUS; i++)
>> +            if (pmu_irqs[i].gsi)
>> +                ++count;
>
> You could more simply with:
>
>      int count = 1
>      ...
>      if (!irq_is_percpu(irq))
>          for (i = 1; i < NR_CPUS; i++)
>              if (pmu_irqs[i].gsi)
>                  ++count;

I think you will notice that the following patch rewrites a lot of this 
function.

I kept the original patches from Mark to identify/segment his 
contribution because they run/bisect by themselves. They should probably 
be squashed together for review purposes.

  reply	other threads:[~2016-03-14  1:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-13 23:23 [RFC 0/4 v3] arm64/perf: Add ACPI support Jeremy Linton
2016-03-13 23:23 ` [PATCH 1/4] arm: pmu: Fix non-devicetree probing Jeremy Linton
2016-03-13 23:23 ` [PATCH 2/4] arm64: pmu: add fallback probe table Jeremy Linton
2016-03-16 21:39   ` nleeder at codeaurora.org
2016-03-13 23:23 ` [PATCH 3/4] arm64: pmu: Add support for probing with ACPI Jeremy Linton
2016-03-13 23:28   ` Timur Tabi
2016-03-14  1:44     ` Jeremy Linton [this message]
2016-03-13 23:23 ` [PATCH 4/4] arm64: pmu: add A72 cpu type, support multiple PMU types Jeremy Linton
  -- strict thread matches above, loose matches on Subject: below --
2016-04-08 21:57 [PATCH 0/4 v3] arm64/perf: Add ACPI support Jeremy Linton
2016-04-08 21:57 ` [PATCH 3/4] arm64: pmu: Add support for probing with ACPI Jeremy Linton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E6177E.6020702@arm.com \
    --to=jeremy.linton@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.