All of lore.kernel.org
 help / color / mirror / Atom feed
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
To: Alberto Garcia <berto@igalia.com>,
	Wen Congyang <wency@cn.fujitsu.com>,
	qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org, qemu-block@nongnu.org,
	Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] quorum: Fix crash in quorum_aio_cb()
Date: Mon, 14 Mar 2016 09:57:31 +0800	[thread overview]
Message-ID: <56E61A8B.2000405@cn.fujitsu.com> (raw)
In-Reply-To: <w51oaall8tk.fsf@maestria.local.igalia.com>

On 03/11/2016 04:25 PM, Alberto Garcia wrote:
> On Fri 11 Mar 2016 02:31:31 AM CET, Wen Congyang wrote:
>> On 03/10/2016 08:13 PM, Alberto Garcia wrote:
>>> quorum_aio_cb() emits the QUORUM_REPORT_BAD event if there's
>>> an I/O error in a Quorum child. However sacb->aiocb must be
>>> correctly initialized for this to happen. read_quorum_children() and
>>> read_fifo_child() are not doing this, which results in a QEMU crash.
>>
>> If we use FIFO mode, we don't call quorum_report_bad() in
>> quorum_aio_cb().  But it is OK to iniialize sacb->aiocb for it.
>

Hi betro

> You're right. I still think it's a good idea to leave it initialized in
> case we change that in the future.

Yes.

>
> And now that we're at it, shouldn't we call quorum_report_bad() in FIFO
> mode as well? Or is there any reason not to do it?

IMO, no reason not to do it.

Thanks
	-Xie

>
> Berto
>
>
>
>

  reply	other threads:[~2016-03-14  1:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-10 12:13 [Qemu-devel] [PATCH] quorum: Fix crash in quorum_aio_cb() Alberto Garcia
2016-03-11  1:31 ` Wen Congyang
2016-03-11  8:25   ` Alberto Garcia
2016-03-14  1:57     ` Changlong Xie [this message]
2016-03-14 13:15       ` Alberto Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E61A8B.2000405@cn.fujitsu.com \
    --to=xiecl.fnst@cn.fujitsu.com \
    --cc=berto@igalia.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=wency@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.