From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 03/22] ncr5380: Remove REAL_DMA and REAL_DMA_POLL macros Date: Mon, 14 Mar 2016 08:23:55 +0100 Message-ID: <56E6670B.9010801@suse.de> References: <20160314042700.596192247@telegraphics.com.au> <20160314042701.376028915@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160314042701.376028915@telegraphics.com.au> Sender: linux-scsi-owner@vger.kernel.org To: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ondrej Zary , Sam Creasey List-Id: linux-m68k@vger.kernel.org On 03/14/2016 05:27 AM, Finn Thain wrote: > For the NCR5380.c core driver, these macros are never used. > If REAL_DMA were to be defined, compilation would fail. >=20 > For the atari_NCR5380.c core driver, REAL_DMA is always defined. >=20 > Hence these macros are pointless. >=20 > Signed-off-by: Finn Thain >=20 > --- > drivers/scsi/NCR5380.c | 218 +-------------------------------= ----------- > drivers/scsi/NCR5380.h | 112 ---------------------- > drivers/scsi/atari_NCR5380.c | 62 +----------- > drivers/scsi/atari_scsi.c | 32 ------ > drivers/scsi/sun3_scsi.c | 13 -- > 5 files changed, 22 insertions(+), 415 deletions(-) >=20 Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: F. Imend=F6rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933414AbcCNHYE (ORCPT ); Mon, 14 Mar 2016 03:24:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:55049 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932463AbcCNHX5 (ORCPT ); Mon, 14 Mar 2016 03:23:57 -0400 Subject: Re: [PATCH 03/22] ncr5380: Remove REAL_DMA and REAL_DMA_POLL macros To: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160314042700.596192247@telegraphics.com.au> <20160314042701.376028915@telegraphics.com.au> Cc: Ondrej Zary , Sam Creasey From: Hannes Reinecke Message-ID: <56E6670B.9010801@suse.de> Date: Mon, 14 Mar 2016 08:23:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160314042701.376028915@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/14/2016 05:27 AM, Finn Thain wrote: > For the NCR5380.c core driver, these macros are never used. > If REAL_DMA were to be defined, compilation would fail. > > For the atari_NCR5380.c core driver, REAL_DMA is always defined. > > Hence these macros are pointless. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 218 +------------------------------------------ > drivers/scsi/NCR5380.h | 112 ---------------------- > drivers/scsi/atari_NCR5380.c | 62 +----------- > drivers/scsi/atari_scsi.c | 32 ------ > drivers/scsi/sun3_scsi.c | 13 -- > 5 files changed, 22 insertions(+), 415 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)