From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 05/22] ncr5380: Disable the DMA errata workaround flag by default Date: Mon, 14 Mar 2016 08:26:45 +0100 Message-ID: <56E667B5.3090708@suse.de> References: <20160314042700.596192247@telegraphics.com.au> <20160314042701.956017683@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160314042701.956017683@telegraphics.com.au> Sender: linux-scsi-owner@vger.kernel.org To: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org Cc: Ondrej Zary , Sam Creasey List-Id: linux-m68k@vger.kernel.org On 03/14/2016 05:27 AM, Finn Thain wrote: > The only chip that needs the workarounds enabled is an early NMOS > device. That means that the common case is to disable them. >=20 > Unfortunately the sense of the flag is such that it has to be set > for the common case. >=20 > Rename the flag so that zero can be used to mean "no errata workaroun= ds > needed". This simplifies the code. >=20 > Signed-off-by: Finn Thain >=20 > --- > drivers/scsi/NCR5380.c | 14 +++++++------- > drivers/scsi/NCR5380.h | 2 +- > drivers/scsi/arm/cumana_1.c | 2 +- > drivers/scsi/arm/oak.c | 2 +- > drivers/scsi/dtc.c | 2 +- > drivers/scsi/g_NCR5380.c | 8 +------- > drivers/scsi/pas16.c | 2 +- > drivers/scsi/t128.c | 2 +- > 8 files changed, 14 insertions(+), 20 deletions(-) >=20 Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: F. Imend=F6rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: hare@suse.de (Hannes Reinecke) Date: Mon, 14 Mar 2016 08:26:45 +0100 Subject: [PATCH 05/22] ncr5380: Disable the DMA errata workaround flag by default In-Reply-To: <20160314042701.956017683@telegraphics.com.au> References: <20160314042700.596192247@telegraphics.com.au> <20160314042701.956017683@telegraphics.com.au> Message-ID: <56E667B5.3090708@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/14/2016 05:27 AM, Finn Thain wrote: > The only chip that needs the workarounds enabled is an early NMOS > device. That means that the common case is to disable them. > > Unfortunately the sense of the flag is such that it has to be set > for the common case. > > Rename the flag so that zero can be used to mean "no errata workarounds > needed". This simplifies the code. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 14 +++++++------- > drivers/scsi/NCR5380.h | 2 +- > drivers/scsi/arm/cumana_1.c | 2 +- > drivers/scsi/arm/oak.c | 2 +- > drivers/scsi/dtc.c | 2 +- > drivers/scsi/g_NCR5380.c | 8 +------- > drivers/scsi/pas16.c | 2 +- > drivers/scsi/t128.c | 2 +- > 8 files changed, 14 insertions(+), 20 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare at suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933667AbcCNH05 (ORCPT ); Mon, 14 Mar 2016 03:26:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:55161 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932155AbcCNH0r (ORCPT ); Mon, 14 Mar 2016 03:26:47 -0400 Subject: Re: [PATCH 05/22] ncr5380: Disable the DMA errata workaround flag by default To: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org References: <20160314042700.596192247@telegraphics.com.au> <20160314042701.956017683@telegraphics.com.au> Cc: Ondrej Zary , Sam Creasey From: Hannes Reinecke Message-ID: <56E667B5.3090708@suse.de> Date: Mon, 14 Mar 2016 08:26:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160314042701.956017683@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/14/2016 05:27 AM, Finn Thain wrote: > The only chip that needs the workarounds enabled is an early NMOS > device. That means that the common case is to disable them. > > Unfortunately the sense of the flag is such that it has to be set > for the common case. > > Rename the flag so that zero can be used to mean "no errata workarounds > needed". This simplifies the code. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 14 +++++++------- > drivers/scsi/NCR5380.h | 2 +- > drivers/scsi/arm/cumana_1.c | 2 +- > drivers/scsi/arm/oak.c | 2 +- > drivers/scsi/dtc.c | 2 +- > drivers/scsi/g_NCR5380.c | 8 +------- > drivers/scsi/pas16.c | 2 +- > drivers/scsi/t128.c | 2 +- > 8 files changed, 14 insertions(+), 20 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)