From: Hans Verkuil <hverkuil@xs4all.nl>
To: Linux Media Mailing List <linux-media@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Subject: Any reason why media_entity_pads_init() isn't void?
Date: Mon, 14 Mar 2016 09:25:51 +0100 [thread overview]
Message-ID: <56E6758F.7020205@xs4all.nl> (raw)
I was fixing a sparse warning in media_entity_pads_init() and I noticed that that
function always returns 0. Any reason why this can't be changed to a void function?
That return value is checked a zillion times in the media code. By making it void
it should simplify code all over.
See e.g. uvc_mc_init_entity in drivers/media/usb/uvc/uvc_entity.c: that whole
function can become a void function itself.
Regards,
Hans
next reply other threads:[~2016-03-14 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 8:25 Hans Verkuil [this message]
2016-03-14 10:24 ` Any reason why media_entity_pads_init() isn't void? Mauro Carvalho Chehab
2016-03-14 10:36 ` Sakari Ailus
2016-03-14 11:27 ` Mauro Carvalho Chehab
2016-03-14 11:43 ` Sakari Ailus
2016-03-14 11:52 ` Mauro Carvalho Chehab
2016-03-14 13:05 ` Mauro Carvalho Chehab
2016-03-14 18:16 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E6758F.7020205@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.