From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 04/10] ARM: dts: Add MSHC2 dt node for Exynos3250 SoC Date: Mon, 14 Mar 2016 18:52:09 +0900 Message-ID: <56E689C9.6030405@samsung.com> References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-5-git-send-email-cw00.choi@samsung.com> <56E658AE.5070806@samsung.com> <56E67632.30602@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:31628 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbcCNJwT (ORCPT ); Mon, 14 Mar 2016 05:52:19 -0400 In-reply-to: <56E67632.30602@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Chanwoo Choi , kgene@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com Cc: jh80.chung@samsung.com, andi.shyti@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, pankaj.dubey@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org On 14.03.2016 17:28, Chanwoo Choi wrote: > On 2016=EB=85=84 03=EC=9B=94 14=EC=9D=BC 15:22, Krzysztof Kozlowski w= rote: >> On 14.03.2016 11:04, Chanwoo Choi wrote: >>> This patch adds the MSHC2 (Mobile Storage Host Controller) Device T= ree node for >>> Exynos3250 SoC. >>> >>> Cc: Kukjin Kim >>> Cc: Krzysztof Kozlowski >>> Signed-off-by: Chanwoo Choi >>> Reviewed-by: Krzysztof Kozlowski >>> --- >>> arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 35 +++++++++++++++++++= ++++++++++++ >>> arch/arm/boot/dts/exynos3250.dtsi | 13 ++++++++++++ >>> 2 files changed, 48 insertions(+) >> >> >> After looking at your other patch ("ARM: dts: Add initial pin >> configuration for exynos3250-rinato") I have doubts. The Monk will b= e >> affected. >=20 > You're right. On monk board, this line may be not stable. >=20 >> >> Here you are configuring all the gpk2 GPIOS for EMMC2 mode. Then on >> Rinato you are setting it back to default non-used state. However th= e >> Monk board will remain with this new configuration... so you would h= ave >> to add initial-state also for Monk. >=20 > OK. I'll do it. >=20 >> >> But how about doing opposite? Configure here the pins to unused stat= e >> and enable them only for Artik board? >> >> What do you think? >=20 > I think that gpk2-[0~6] pins are fixed for MMC2 device. > So, it is good to add the pin setting for gpk2-[0~6] to exynos3250-pi= nctrl.dtsi. >=20 > If mmc2 device is not used like rinato and monk board, > we should add the initial setting as NC (not connected) pin state > as other patch (ARM: dts: Add initial pin configuration for exynos325= 0-rinato). Okay, fine to me. BR, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Mon, 14 Mar 2016 18:52:09 +0900 Subject: [PATCH 04/10] ARM: dts: Add MSHC2 dt node for Exynos3250 SoC In-Reply-To: <56E67632.30602@samsung.com> References: <1457921056-21257-1-git-send-email-cw00.choi@samsung.com> <1457921056-21257-5-git-send-email-cw00.choi@samsung.com> <56E658AE.5070806@samsung.com> <56E67632.30602@samsung.com> Message-ID: <56E689C9.6030405@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 14.03.2016 17:28, Chanwoo Choi wrote: > On 2016? 03? 14? 15:22, Krzysztof Kozlowski wrote: >> On 14.03.2016 11:04, Chanwoo Choi wrote: >>> This patch adds the MSHC2 (Mobile Storage Host Controller) Device Tree node for >>> Exynos3250 SoC. >>> >>> Cc: Kukjin Kim >>> Cc: Krzysztof Kozlowski >>> Signed-off-by: Chanwoo Choi >>> Reviewed-by: Krzysztof Kozlowski >>> --- >>> arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 35 +++++++++++++++++++++++++++++++ >>> arch/arm/boot/dts/exynos3250.dtsi | 13 ++++++++++++ >>> 2 files changed, 48 insertions(+) >> >> >> After looking at your other patch ("ARM: dts: Add initial pin >> configuration for exynos3250-rinato") I have doubts. The Monk will be >> affected. > > You're right. On monk board, this line may be not stable. > >> >> Here you are configuring all the gpk2 GPIOS for EMMC2 mode. Then on >> Rinato you are setting it back to default non-used state. However the >> Monk board will remain with this new configuration... so you would have >> to add initial-state also for Monk. > > OK. I'll do it. > >> >> But how about doing opposite? Configure here the pins to unused state >> and enable them only for Artik board? >> >> What do you think? > > I think that gpk2-[0~6] pins are fixed for MMC2 device. > So, it is good to add the pin setting for gpk2-[0~6] to exynos3250-pinctrl.dtsi. > > If mmc2 device is not used like rinato and monk board, > we should add the initial setting as NC (not connected) pin state > as other patch (ARM: dts: Add initial pin configuration for exynos3250-rinato). Okay, fine to me. BR, Krzysztof