From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PART1 RFC v2 03/10] svm: Introduce new AVIC VMCB registers Date: Mon, 14 Mar 2016 13:25:24 +0100 Message-ID: <56E6ADB4.9040700@redhat.com> References: <1457124368-2025-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1457124368-2025-4-git-send-email-Suravee.Suthikulpanit@amd.com> <56DDA1CF.4080207@redhat.com> <56E66B43.1000802@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wei@redhat.com, sherry.hurwitz@amd.com To: Suravee Suthikulpanit , rkrcmar@redhat.com, joro@8bytes.org, bp@alien8.de, gleb@kernel.org, alex.williamson@redhat.com Return-path: Received: from mail-wm0-f54.google.com ([74.125.82.54]:37877 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964849AbcCNMZe (ORCPT ); Mon, 14 Mar 2016 08:25:34 -0400 In-Reply-To: <56E66B43.1000802@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 14/03/2016 08:41, Suravee Suthikulpanit wrote: > Any particular reason why you do not recommend the use of bit field? 1) The current coding style is generally not using bitfields 2) Having to review patches that change working code unrelated to AVIC 3) Most of the fields are not even used when AVIC is enabled, so the benefit of the conversion is small. Paolo