From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig Date: Mon, 14 Mar 2016 09:05:12 -0500 Message-ID: <56E6C518.1070706@cardoe.com> References: <1457376161-24982-1-git-send-email-cardoe@cardoe.com> <1457376161-24982-2-git-send-email-cardoe@cardoe.com> <56DEAD8602000078000DA45D@prv-mh.provo.novell.com> <56DEFC58.9090801@tycho.nsa.gov> <56DF112F02000078000DA884@prv-mh.provo.novell.com> <56DF138D.8080001@tycho.nsa.gov> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2058535118262597405==" Return-path: In-Reply-To: <56DF138D.8080001@tycho.nsa.gov> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Daniel De Graaf , Jan Beulich Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2058535118262597405== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0aMghffPwXI5aqDt5xTuVsuUx1hBm4CtU" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0aMghffPwXI5aqDt5xTuVsuUx1hBm4CtU Content-Type: multipart/mixed; boundary="kIleBCFJdmn6Td33er3aXGxfEsQfinekp" From: Doug Goldstein To: Daniel De Graaf , Jan Beulich Cc: xen-devel@lists.xen.org Message-ID: <56E6C518.1070706@cardoe.com> Subject: Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig References: <1457376161-24982-1-git-send-email-cardoe@cardoe.com> <1457376161-24982-2-git-send-email-cardoe@cardoe.com> <56DEAD8602000078000DA45D@prv-mh.provo.novell.com> <56DEFC58.9090801@tycho.nsa.gov> <56DF112F02000078000DA884@prv-mh.provo.novell.com> <56DF138D.8080001@tycho.nsa.gov> In-Reply-To: <56DF138D.8080001@tycho.nsa.gov> --kIleBCFJdmn6Td33er3aXGxfEsQfinekp Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/8/16 12:01 PM, Daniel De Graaf wrote: > On 03/08/2016 11:51 AM, Jan Beulich wrote: >>>>> On 08.03.16 at 17:22, wrote: >>> On 03/08/2016 04:46 AM, Jan Beulich wrote: >>>>>>> On 07.03.16 at 19:42, wrote: >>>>> Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with >>>>> CONFIG_ >>>>> to use the Kconfig variable. >>>> >>>> Same question here: What's the benefit of doing it this way? >>> >>> This removes the stats tracking, which might (I have not tested) >>> speed up >>> the security server by avoiding the __get_cpu_var call and increment.= >> >> No, I don not think the patch removes anything. The Kconfig option >> doesn't have a prompt. But anyway, ... >=20 > Ah, I missed that: I saw the --help-- line and assumed it was the promp= t. > Either way, this #define is a configuration-like knob that doesn't need= to > be hard-coded in a header as it currently is. >=20 >> >>> The >>> corresponding SELinux knob is a Kconfig option in Linux. >>> >>> Acked-by: Daniel De Graaf >> >> ... if you're fine with it, we'll put it in (once the mechanical issue= s >> got addressed). >=20 Daniel, Would you like me to make this a real configuration option? Or proceed with the current path and we can make a configuration option later? --=20 Doug Goldstein --kIleBCFJdmn6Td33er3aXGxfEsQfinekp-- --0aMghffPwXI5aqDt5xTuVsuUx1hBm4CtU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJW5sUbXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUTZMP/0vtmwKt55AOsZE7BmFlZo5n ADzT0kYIP986fSHmLXiOo/JYauADPFhM3nzP28CvZHMbvzdqMPagMJduhk42mr9T krM+ShnKp5u9PPL62w+ZTDzPicxJ74hBLg+qENhcu8Ssdnm0MQd+dz4S4wxgcC+i UE8Wjf1zl3R1aqeK2eYFiMxWoInltNPoTbiQZ1JnUC2bbgh9wiftJRdE3OZFl2n2 wWLkWlbmS3vkirBJcd3QvPaVyyG6RZodXBHQ+SomG0C3SL8AMivEWZ0xZ0F+esg+ P1EKFWeZguneVfk4aucUAA78spPRs5ykl1PnhoNu51jkWukeiBDGMGN7uSDcxPGU zAIqwWVMcAAJr7c8+z0VWCBy4/69yzlsWIRL3wULRTOKGkpDbhwodsyJQTShMs/2 NX2xh58Pu08rulP7Cv7u85dvfhviGK2YcZGhSp/mjqI51TY3l+TLLjwLpTKAxAqd 7tGFuDv8vRBvFQHNvrgWk1R1Nvd/lzQaYgfBazNMDx2YugBWYCTivxxZbQiaEjps H9YfF9JOywzJ1lxzZtkh5QNc/qNPlIw2orjzWRyQNn92vbkPOBH4NKawtXJolGT1 FQhCVfuk4Gf7ozxHZRGyEcQtHMqXQubZ3fdbAgMqGp35fA4Ow6rPpGW+/qx23RSz 9+lxPE20up3wuzzXqdAK =VLBM -----END PGP SIGNATURE----- --0aMghffPwXI5aqDt5xTuVsuUx1hBm4CtU-- --===============2058535118262597405== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============2058535118262597405==--