From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afUlj-0000hi-H3 for qemu-devel@nongnu.org; Mon, 14 Mar 2016 11:50:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afUlf-0003yi-BN for qemu-devel@nongnu.org; Mon, 14 Mar 2016 11:50:55 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:38846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afUle-0003yZ-WB for qemu-devel@nongnu.org; Mon, 14 Mar 2016 11:50:51 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 14 Mar 2016 15:50:49 -0000 References: <1447201710-10229-1-git-send-email-benh@kernel.crashing.org> <1447201710-10229-73-git-send-email-benh@kernel.crashing.org> <56D74D5E.9090307@redhat.com> <56E081E1.5020003@fr.ibm.com> <56E092DE.5040101@redhat.com> <56E1B665.5040909@redhat.com> <56E1F4E9.5050307@fr.ibm.com> <56E29820.5000500@redhat.com> <56E2D48B.4070509@fr.ibm.com> <56E2DA46.6080702@redhat.com> <56E6D076.9030409@fr.ibm.com> <56E6DC0E.20406@redhat.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <56E6DDC9.9050209@fr.ibm.com> Date: Mon, 14 Mar 2016 16:50:33 +0100 MIME-Version: 1.0 In-Reply-To: <56E6DC0E.20406@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 72/77] ppc: A couple more dummy POWER8 Book4 regs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-ppc@nongnu.org Cc: qemu-devel@nongnu.org On 03/14/2016 04:43 PM, Thomas Huth wrote: > On 14.03.2016 15:53, Cédric Le Goater wrote: >> Hello Thomas, >> >> On 03/11/2016 03:46 PM, Thomas Huth wrote: >>> I'd maybe also squash the "Add KVM numbers to some P8 SPRs" patch into >>> the "Add a bunch of hypervisor SPRs to Book3s" to reduce the code churn >>> a little bit (note that the patch description for the "Add a bunch of >>> hypervisor SPRs to Book3s" patch is misleading - DAWR and DAWRX need to >>> be synchronized for migration, since the guest can set this register via >>> the H_SET_MODE hypercall). >> >> So shall I just remove the comment : >> >> "We don't give them a KVM reg number yet as no current KVM version >> supports HV mode." >> >> from patch "Add a bunch of hypervisor SPRs to Book3s" after squashing in >> "Add KVM numbers to some P8 SPRs" ? > > Either that, or change it into something like: > > "We don't give them a KVM reg number to most of the registers yet as no > current KVM version supports HV mode. For DAWR and DAWRX, the KVM reg > number is needed since this register can be set by the guest via the > H_SET_MODE hypercall." OK. Good. I should be sending a first patchset soon the list, after a few checks. Thanks, C.