From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afVWc-0003v6-Vg for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:39:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afVWc-0000oW-6W for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:39:22 -0400 Received: from mail-ob0-x22c.google.com ([2607:f8b0:4003:c01::22c]:34755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afVWc-0000oP-0i for qemu-devel@nongnu.org; Mon, 14 Mar 2016 12:39:22 -0400 Received: by mail-ob0-x22c.google.com with SMTP id ts10so182117310obc.1 for ; Mon, 14 Mar 2016 09:39:21 -0700 (PDT) References: <1457972631-1376-1-git-send-email-minyard@acm.org> <56E6E7DE.1040208@redhat.com> From: Corey Minyard Message-ID: <56E6E938.6000403@mvista.com> Date: Mon, 14 Mar 2016 23:39:20 +0700 MIME-Version: 1.0 In-Reply-To: <56E6E7DE.1040208@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Sort the fw_cfg file list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , minyard@acm.org, qemu-devel@nongnu.org, "Michael S. Tsirkin" Cc: Gerd Hoffmann On 03/14/2016 11:33 PM, Paolo Bonzini wrote: > > On 14/03/2016 17:23, minyard@acm.org wrote: >> From: Gerd Hoffmann >> >> Entries are inserted at the correct place instead of being >> appended to the end in case sorting is enabled. >> >> Signed-off-by: Gerd Hoffmann >> >> Added a new machine type for compatibility. >> >> Signed-off-by: Corey Minyard >> --- >> >> I don't really like the double-negative created by dont_sort_fw_cfgs, >> but it seems more consistent with the other fields (no_floppy, etc.) >> where the default is 0 and the compat is 1. > You can use the 2.6 machine type too. Oh, duh. Yeah, I should use that. Thanks, -corey