All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Moritz Fischer <moritz.fischer@ettus.com>, <nicolas.ferre@atmel.com>
Cc: <michal.simek@xilinx.com>, <joe@perches.com>,
	<davem@davemloft.net>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<moritz.fischer.private@gmail.com>
Subject: Re: [PATCH 1/5] net: macb: Fix coding style error message
Date: Mon, 14 Mar 2016 21:47:13 +0100	[thread overview]
Message-ID: <56E72351.8020302@xilinx.com> (raw)
In-Reply-To: <1457896247-25934-2-git-send-email-moritz.fischer@ettus.com>

On 13.3.2016 20:10, Moritz Fischer wrote:
> checkpatch.pl gave the following error:
> 
> ERROR: space required before the open parenthesis '('
> +	for(; p < end; p++, offset += 4)
> 
> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
>  drivers/net/ethernet/cadence/macb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 50c9410..4370f37 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -496,7 +496,7 @@ static void macb_update_stats(struct macb *bp)
>  
>  	WARN_ON((unsigned long)(end - p - 1) != (MACB_TPF - MACB_PFR) / 4);
>  
> -	for(; p < end; p++, offset += 4)
> +	for (; p < end; p++, offset += 4)
>  		*p += bp->macb_reg_readl(bp, offset);
>  }
>  
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

  reply	other threads:[~2016-03-14 20:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-13 19:10 [PATCH 0/5] net: macb: Checkpatch cleanups Moritz Fischer
2016-03-13 19:10 ` [PATCH 1/5] net: macb: Fix coding style error message Moritz Fischer
2016-03-14 20:47   ` Michal Simek [this message]
2016-03-16 13:39   ` Nicolas Ferre
2016-03-13 19:10 ` [PATCH 2/5] net: macb: Fix coding style warnings Moritz Fischer
2016-03-14 20:53   ` Michal Simek
2016-03-16 13:46     ` Nicolas Ferre
2016-03-13 19:10 ` [PATCH 3/5] net: macb: Address checkpatch 'check' suggestions Moritz Fischer
2016-03-14 20:49   ` Michal Simek
2016-03-16 13:46   ` Nicolas Ferre
2016-03-13 19:10 ` [PATCH 4/5] net: macb: Use ether_addr_copy over memcpy Moritz Fischer
2016-03-14 20:48   ` Michal Simek
2016-03-16 13:48   ` Nicolas Ferre
2016-03-13 19:10 ` [PATCH 5/5] net: macb: Fix simple typo Moritz Fischer
2016-03-14 20:47   ` Michal Simek
2016-03-16 13:51     ` Nicolas Ferre
2016-03-16 13:39 ` [PATCH 0/5] net: macb: Checkpatch cleanups Nicolas Ferre
2016-03-16 16:30   ` Moritz Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E72351.8020302@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=moritz.fischer.private@gmail.com \
    --cc=moritz.fischer@ettus.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.