All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joseph Qi <joseph.qi@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] Could the master return DLM_NORMAL when unlock nonexistent locks from other node?
Date: Tue, 15 Mar 2016 10:32:19 +0800	[thread overview]
Message-ID: <56E77433.6000007@huawei.com> (raw)
In-Reply-To: <D1E4D02760513D4B90DC3B40FF32AF355EE2304D@H3CMLB14-EX.srv.huawei-3com.com>

Hi Changkuo,
I don't agree with you.
The case you described is a real bug. From the description, I think it's
a race that leads Node B has already purged the lockres, while Node A
still thinks it is already there. So IMO, we have to figure out why can
it happen, but not treat it as normal.

Thanks,
Joseph

On 2016/3/15 9:55, Shichangkuo wrote:
> Hi all,
>     When NodeA want to unlock lock-res1, and it send message to NodeB, but in NodeB any lock queues (granted, converting, blocked) could not find this lock for some unknown reason, then NodeB reply DLM_IVLOCKID.
>     In this situation, NodeA bug. The detail is described as follows.
> 
>         NODEA                                              NODEB
> ocfs2_drop_lock
>     ocfs2_dlm_unlock
>         o2cb_dlm_unlock
>             dlmunlock
>                 dlmunlock_remote        ---->   send message to master
>                                                   dlm_unlock_lock_handler
>                                                       return DLM_IVLOCKID
>     BUG()
> 
> I think it's no nessary to let NodeA bug, it just like we removed an nonexistent file.
> Could NodeB return DLM_NORMAL?
> 
> Thanks
> Changkuo
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
> -------------------------------------------------------------------------------------------------------------------------------------
> ????????????????????????????????????????
> ????????????????????????????????????????
> ????????????????????????????????????????
> ???
> This e-mail and its attachments contain confidential information from H3C, which is
> intended only for the person or entity whose address is listed above. Any use of the
> information contained herein in any way (including, but not limited to, total or partial
> disclosure, reproduction, or dissemination) by persons other than the intended
> recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender
> by phone or email immediately and delete it!
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
> 

  reply	other threads:[~2016-03-15  2:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15  1:55 [Ocfs2-devel] Could the master return DLM_NORMAL when unlock nonexistent locks from other node? Shichangkuo
2016-03-15  2:32 ` Joseph Qi [this message]
2016-03-15  2:34 ` Gang He
2016-03-17  1:15 ` Junxiao Bi
  -- strict thread matches above, loose matches on Subject: below --
2016-03-15  3:51 Shichangkuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E77433.6000007@huawei.com \
    --to=joseph.qi@huawei.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.