From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55123)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lizhijian@cn.fujitsu.com>) id 1affk4-00015E-Fk
	for qemu-devel@nongnu.org; Mon, 14 Mar 2016 23:33:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lizhijian@cn.fujitsu.com>) id 1affk1-0006Xs-7z
	for qemu-devel@nongnu.org; Mon, 14 Mar 2016 23:33:56 -0400
Received: from [59.151.112.132] (port=64135 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lizhijian@cn.fujitsu.com>) id 1affk0-0006Xg-Sa
	for qemu-devel@nongnu.org; Mon, 14 Mar 2016 23:33:53 -0400
References: <1457345011-17645-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<CAN+wFu+P3J89SzxV-=nS+hziXqQ4DFi7mWpFkDNR_i47MXNhgQ@mail.gmail.com>
	<56DFD89E.4040508@cn.fujitsu.com> <56E77CC1.7050307@redhat.com>
From: Li Zhijian <lizhijian@cn.fujitsu.com>
Message-ID: <56E78299.9040102@cn.fujitsu.com>
Date: Tue, 15 Mar 2016 11:33:45 +0800
MIME-Version: 1.0
In-Reply-To: <56E77CC1.7050307@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] net/filter: rename
 qemu_netfilter_pass_to_next() to qemu_netfilter_iterate()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>, Yang Hongyang <hongyang.yang@easystack.cn>, Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Cc: Gui jianfeng <guijianfeng@cn.fujitsu.com>, "eddie.dong" <eddie.dong@intel.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, qemu devel <qemu-devel@nongnu.org>



On 03/15/2016 11:08 AM, Jason Wang wrote:
>
>
> On 03/09/2016 04:02 PM, Li Zhijian wrote:
>>
>>
>> On 03/08/2016 04:04 PM, Yang Hongyang wrote:
>>> Hi Chen,
>>>
>>>     What's the motivation that you want to change this name? The
>>> function actually is not
>>> intent to iterate every filter.
>>
>> Right. but this function isn't always pass packet to *a* next filter.
>> Actually, it iterates filters until the packet is stolen(filter
>> receiving handler return non-zero).
>> In other words, packet could be handled by several filters at this
>> function.
>>
>> BTW, it's difficult to determine what name is better.
>>
>> Thanks
>> Li Zhijian
>
> Right, so I was considering a better function name (though I'm not a
> native English speaker).
>
> But I agree qemu_netfilter_iterate() is not perfect too, may need more
> thought.
>
>
let's drop this patch temporarily ?

Thanks
Li Zhijian