From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Ni Subject: Re: [PATCH V7 00/12] Add T210 support in Tegra soctherm Date: Tue, 15 Mar 2016 13:46:55 +0800 Message-ID: <56E7A1CF.4060302@nvidia.com> References: <1457665763-29781-1-git-send-email-wni@nvidia.com> <20160314210152.GA4717@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160314210152.GA4717-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eduardo Valentin Cc: rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, MLongnecker-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, mikko.perttunen-/1wQRMveznE@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-pm@vger.kernel.org On 2016=E5=B9=B403=E6=9C=8815=E6=97=A5 05:01, Eduardo Valentin wrote: > * PGP Signed by an unknown key >=20 > On Fri, Mar 11, 2016 at 11:09:11AM +0800, Wei Ni wrote: >> This patchset adds following functions for tegra_soctherm driver: >> 1. add T210 support. >=20 > It would be good to update the compatible string in the binding > documentation. The commit "193c9d23a0f0 Documentation: DT bindings: add more Tegra chi= p compatible strings" already add compatible string for Tegra210. >=20 >> 2. export debugfs to show some registers. >> 3. add thermtrip funciton. >> 4. add suspend/resume function. >=20 > Thanks for your effort in keeping up with upstream. I think overall t= he > series is good, I had only very few comments (in response to each > patch). Thanks for your review. I will check these comments, and update my patc= hes in next few days. Wei. >=20 > BR, >=20 > Eduardo Valentin >=20 >=20 >> >> >> --=20 >> 1.9.1 >> >=20 > * Unknown Key > * 0x7DA4E256 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754716AbcCOFqz (ORCPT ); Tue, 15 Mar 2016 01:46:55 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:4613 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752838AbcCOFqs convert rfc822-to-8bit (ORCPT ); Tue, 15 Mar 2016 01:46:48 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Mon, 14 Mar 2016 22:46:02 -0700 Message-ID: <56E7A1CF.4060302@nvidia.com> Date: Tue, 15 Mar 2016 13:46:55 +0800 From: Wei Ni User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Eduardo Valentin CC: , , , , , , , Subject: Re: [PATCH V7 00/12] Add T210 support in Tegra soctherm References: <1457665763-29781-1-git-send-email-wni@nvidia.com> <20160314210152.GA4717@localhost.localdomain> In-Reply-To: <20160314210152.GA4717@localhost.localdomain> X-Originating-IP: [10.19.224.146] X-ClientProxiedBy: DRBGMAIL104.nvidia.com (10.18.16.23) To HKMAIL101.nvidia.com (10.18.16.10) Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年03月15日 05:01, Eduardo Valentin wrote: > * PGP Signed by an unknown key > > On Fri, Mar 11, 2016 at 11:09:11AM +0800, Wei Ni wrote: >> This patchset adds following functions for tegra_soctherm driver: >> 1. add T210 support. > > It would be good to update the compatible string in the binding > documentation. The commit "193c9d23a0f0 Documentation: DT bindings: add more Tegra chip compatible strings" already add compatible string for Tegra210. > >> 2. export debugfs to show some registers. >> 3. add thermtrip funciton. >> 4. add suspend/resume function. > > Thanks for your effort in keeping up with upstream. I think overall the > series is good, I had only very few comments (in response to each > patch). Thanks for your review. I will check these comments, and update my patches in next few days. Wei. > > BR, > > Eduardo Valentin > > >> >> >> -- >> 1.9.1 >> > > * Unknown Key > * 0x7DA4E256 >