All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: "Nicolai Hähnle" <nicolai.haehnle@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: Oops (NULL pointer dereference) in radeon_fence_ref in 3.14.63
Date: Tue, 15 Mar 2016 15:45:56 +0900	[thread overview]
Message-ID: <56E7AFA4.8020904@daenzer.net> (raw)
In-Reply-To: <56DE3EF2.7070609@amd.com>

On 08.03.2016 11:54, Nicolai Hähnle wrote:
> On 05.03.2016 16:24, Christian König wrote:
>> just an educated guess, but I think the problem is simply that kernel
>> 3.14 doesn't yet contain the code so that radeon_fence_get() can safely
>> called with a NULL pointer.
>>
>> So the backport of Nicolai's patch needs and extra check for the case
>> when the fence is NULL.
> 
> Oops indeed. Only the ref call should need the guard, the unref has
> always had a NULL pointer test as far as I can see.
> 
> Lutz, could you please test whether the attached patch on top of 3.14.63
> fixes the problem?

Nicolai, if you haven't already, please send this patch to
stable@vger.kernel.org with an explicit explanation of which stable
branches need it.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2016-03-15  6:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-05 17:16 Oops (NULL pointer dereference) in radeon_fence_ref in 3.14.63 Lutz Euler
2016-03-05 19:24 ` Christian König
2016-03-08  2:54   ` Nicolai Hähnle
2016-03-08  8:50     ` Christian König
2016-03-11 18:06     ` Lutz Euler
2016-03-15  6:45     ` Michel Dänzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E7AFA4.8020904@daenzer.net \
    --to=michel@daenzer.net \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=nicolai.haehnle@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.