From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47226)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1afjt1-0001v2-06
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 03:59:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1afjsw-0006xj-Uw
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 03:59:26 -0400
Received: from [59.151.112.132] (port=24758 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1afjsw-0006wX-Ch
	for qemu-devel@nongnu.org; Tue, 15 Mar 2016 03:59:22 -0400
References: <1457014732-19428-1-git-send-email-marcel@redhat.com>
From: Cao jin <caoj.fnst@cn.fujitsu.com>
Message-ID: <56E7C13B.6010601@cn.fujitsu.com>
Date: Tue, 15 Mar 2016 16:00:59 +0800
MIME-Version: 1.0
In-Reply-To: <1457014732-19428-1-git-send-email-marcel@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V4] hw/pxb: add chassis_nr property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel@redhat.com>, qemu-devel@nongnu.org
Cc: marcel@hdredirect-lb-399551664.us-east-1.elb.amazonaws.com, ehabkost@redhat.com, laine@redhat.com, mst@redhat.com

Hi,

On 03/03/2016 10:18 PM, Marcel Apfelbaum wrote:
> Add a chassis_nr property instead of using PXB bus number
> as internal bridge's chassis nr.
>
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
> v3->v4:
>   - re-coded to fit current codebase
> v2->v3:
>   - use bus nr if chassis nr is 0 (Micahel S. Tsirkin)
> v1->v2:
>   - Rebased on master
>
>   docs/pci_expander_bridge.txt        |  7 +++----
>   hw/pci-bridge/pci_expander_bridge.c | 21 +++++++++++++++++++--
>   2 files changed, 22 insertions(+), 6 deletions(-)
>

>
> @@ -286,6 +294,8 @@ static Property pxb_dev_properties[] = {
>       /* Note: 0 is not a legal a PXB bus number. */

better remove the latter "a", or I guess it will conflict with my 
previous pxb cleanup patch.

>       DEFINE_PROP_UINT8("bus_nr", PXBDev, bus_nr, 0),
>       DEFINE_PROP_UINT16("numa_node", PXBDev, numa_node, NUMA_NODE_UNASSIGNED),
> +    /* Note: 0 is not a legal chassis number. */
> +    DEFINE_PROP_UINT8("chassis_nr", PXBDev, chassis_nr, 0),
>       DEFINE_PROP_END_OF_LIST(),
>   };
>
> @@ -322,6 +332,13 @@ static int pxb_pcie_dev_initfn(PCIDevice *dev)
>       return pxb_dev_init_common(dev, true);
>   }
>
> +static Property pxb_pcie_dev_properties[] = {
> +    /* Note: 0 is not a legal a PXB bus number. */

likewise

> +    DEFINE_PROP_UINT8("bus_nr", PXBDev, bus_nr, 0),
> +    DEFINE_PROP_UINT16("numa_node", PXBDev, numa_node, NUMA_NODE_UNASSIGNED),
> +    DEFINE_PROP_END_OF_LIST(),
> +};

And I have another personal question: In qemu design, it seems every pci 
bridge reside in a separate chassis, what`s benefit?  why don`t put them 
all in the main chassis?

-- 
Yours Sincerely,

Cao jin