From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Subject: Re: [RFC] [PATCH v3] can: fix handling of unmodifiable configuration options Date: Tue, 15 Mar 2016 09:17:06 +0100 Message-ID: <56E7C502.4080109@hartkopp.net> References: <1457982490-27520-1-git-send-email-socketcan@hartkopp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.216]:18030 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933992AbcCOIRV (ORCPT ); Tue, 15 Mar 2016 04:17:21 -0400 In-Reply-To: Sender: linux-can-owner@vger.kernel.org List-ID: To: Ramesh Shanmugasundaram , "linux-can@vger.kernel.org" , Marc Kleine-Budde , Stephane Grosjean Hello Marc, On 03/15/2016 08:15 AM, Ramesh Shanmugasundaram wrote: >> Oliver Hartkopp >> Subject: [RFC] [PATCH v3] can: fix handling of unmodifiable configuration >> options (..) >> Reported-by: Ramesh Shanmugasundaram >> Signed-off-by: Oliver Hartkopp > > Reviewed-by: Ramesh Shanmugasundaram > Tested-by: Ramesh Shanmugasundaram > I would suggest to queue this patch for stable 3.18+ where I applies without problems. Ubuntu maintains a 3.16 longterm kernel - but I do not see a real benefit for that kernel as it would only affect the M_CAN driver there. I doubt any M_CAN hardware is used together with this specific Ubuntu kernel as we already would have get any feedback then. Once this patch emerged in Linux 4.0 I'll send a patch for the PCAN USB FD adapters which are potential can_set_static_ctrlmode() users too. Best regards, Oliver