All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Hellstrom <thellstrom@vmware.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 13/14] drm: Adjust the maximum value of suggested [X|Y] properties
Date: Tue, 15 Mar 2016 09:32:22 +0100	[thread overview]
Message-ID: <56E7C896.6090505@vmware.com> (raw)
In-Reply-To: <20160315081440.GT14170@phenom.ffwll.local>

On 03/15/2016 09:14 AM, Daniel Vetter wrote:
> On Tue, Mar 15, 2016 at 08:30:03AM +0100, Thomas Hellstrom wrote:
>> X re-export these values as 32-bit, so they end up as -1.
>>
>> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
> Imo that's a bug in X, and X should clamp the range itself. Not the
> kernel. Prop abi is pretty consistent that its all 64bit values.
> -Daniel

True. Otoh, we can't really change old X servers to support this, and
the range doesn't really need to be that large.
(It's already restricted to 32 bits and restricting it to 31 bits
doesn't make a big difference).

/Thomas


>
>> ---
>>  drivers/gpu/drm/drm_crtc.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
>> index 8451400..a27b2e0 100644
>> --- a/drivers/gpu/drm/drm_crtc.c
>> +++ b/drivers/gpu/drm/drm_crtc.c
>> @@ -1789,10 +1789,10 @@ int drm_mode_create_suggested_offset_properties(struct drm_device *dev)
>>  		return 0;
>>  
>>  	dev->mode_config.suggested_x_property =
>> -		drm_property_create_range(dev, DRM_MODE_PROP_IMMUTABLE, "suggested X", 0, 0xffffffff);
>> +		drm_property_create_range(dev, DRM_MODE_PROP_IMMUTABLE, "suggested X", 0, 0x7fffffff);
>>  
>>  	dev->mode_config.suggested_y_property =
>> -		drm_property_create_range(dev, DRM_MODE_PROP_IMMUTABLE, "suggested Y", 0, 0xffffffff);
>> +		drm_property_create_range(dev, DRM_MODE_PROP_IMMUTABLE, "suggested Y", 0, 0x7fffffff);
>>  
>>  	if (dev->mode_config.suggested_x_property == NULL ||
>>  	    dev->mode_config.suggested_y_property == NULL)
>> -- 
>> 2.5.0
>>
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_dri-2Ddevel&d=BQIBAg&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=vpukPkBtpoNQp2IUKuFviOmPNYWVKmen3Jeeu55zmEA&m=tk1_0FQoUlZD2ybivU9sASZgACk0FHEeIHWhp07U3Z0&s=2G9Zzwff6weMglpvwYsaZF9e1ginaxM62nYFBU0x2Bs&e= 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-03-15  8:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15  7:29 [PATCH 01/14] drm/vmwgfx: Add DXGenMips support Thomas Hellstrom
2016-03-15  7:29 ` [PATCH 02/14] drm/vmwgfx: Fix a screen object framebuffer dirty corner case Thomas Hellstrom
2016-03-15  7:29 ` [PATCH 03/14] drm/vmwgfx: Fix screen object page flips for large framebuffers Thomas Hellstrom
2016-03-15  7:29 ` [PATCH 04/14] drm/vmwgfx: Rework screen target page flips v2 Thomas Hellstrom
2016-03-15  7:29 ` [PATCH 05/14] drm/vmwgfx: Break out implicit fb code Thomas Hellstrom
2016-03-15  7:29 ` [PATCH 06/14] drm/vmwgfx: Add implicit framebuffer checks to the screen target code Thomas Hellstrom
2016-03-15  7:29 ` [PATCH 07/14] drm/vmwgfx: Add suggested screen x and y connector properties Thomas Hellstrom
2016-03-15  7:29 ` [PATCH 08/14] drm/vmwgfx: Add connector properties to switch between explicit and implicit placement Thomas Hellstrom
2016-03-15  7:29 ` [PATCH 09/14] drm/vmwgfx: Calculate the cursor position based on the crtc gui origin Thomas Hellstrom
2016-03-15  7:30 ` [PATCH 10/14] drm/vmwgfx: Default to explicit crtc placement for screen targets and screen objects Thomas Hellstrom
2016-03-15  7:30 ` [PATCH 11/14] drm/vmwgfx: Send a hotplug event at master_set Thomas Hellstrom
2016-03-15  7:30 ` [PATCH 12/14] drm/vmwgfx: Allow the UPDATE_LAYOUT ioctl from control nodes Thomas Hellstrom
2016-03-15  7:30 ` [PATCH 13/14] drm: Adjust the maximum value of suggested [X|Y] properties Thomas Hellstrom
2016-03-15  8:14   ` Daniel Vetter
2016-03-15  8:32     ` Thomas Hellstrom [this message]
2016-03-15  9:23       ` Daniel Vetter
2016-03-15  9:25         ` Daniel Vetter
2016-03-15  9:26         ` Thomas Hellstrom
2016-03-15  7:30 ` [PATCH 14/14] drm/vmwgfx: Bump driver minor Thomas Hellstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E7C896.6090505@vmware.com \
    --to=thellstrom@vmware.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.