All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
	Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	Stephane Grosjean <s.grosjean@peak-system.com>
Subject: Re: [RFC] [PATCH v3] can: fix handling of unmodifiable configuration options
Date: Tue, 15 Mar 2016 10:22:38 +0100	[thread overview]
Message-ID: <56E7D45E.8040404@pengutronix.de> (raw)
In-Reply-To: <56E7C502.4080109@hartkopp.net>


[-- Attachment #1.1: Type: text/plain, Size: 1562 bytes --]

On 03/15/2016 09:17 AM, Oliver Hartkopp wrote:
> Hello Marc,
> 
> On 03/15/2016 08:15 AM, Ramesh Shanmugasundaram wrote:
>>> Oliver Hartkopp <socketcan@hartkopp.net>
>>> Subject: [RFC] [PATCH v3] can: fix handling of unmodifiable configuration
>>> options
> 
> (..)
> 
>>> Reported-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
>>> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
>>
>> Reviewed-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
>> Tested-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
>>
> 
> I would suggest to queue this patch for stable 3.18+ where I applies 
> without problems.

Ok, I've added:

Cc: <stable@vger.kernel.org> # >= 3.18

> Ubuntu maintains a 3.16 longterm kernel - but I do not see a real 
> benefit for that kernel as it would only affect the M_CAN driver there. 
> I doubt any M_CAN hardware is used together with this specific Ubuntu 
> kernel as we already would have get any feedback then.
> 
> Once this patch emerged in Linux 4.0 I'll send a patch for the PCAN USB 
> FD adapters which are potential can_set_static_ctrlmode() users too.

No need to wait, you can send the patches now. They'll go via can-next
anyway.

regards,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

      reply	other threads:[~2016-03-15  9:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14 19:08 [RFC] [PATCH v3] can: fix handling of unmodifiable configuration options Oliver Hartkopp
2016-03-15  7:15 ` Ramesh Shanmugasundaram
2016-03-15  8:17   ` Oliver Hartkopp
2016-03-15  9:22     ` Marc Kleine-Budde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E7D45E.8040404@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    --cc=ramesh.shanmugasundaram@bp.renesas.com \
    --cc=s.grosjean@peak-system.com \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.