All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Corey Minyard <cminyard@mvista.com>,
	qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/
Date: Tue, 15 Mar 2016 15:54:36 +0100	[thread overview]
Message-ID: <56E8222C.7090909@redhat.com> (raw)
In-Reply-To: <20160315161755-mutt-send-email-mst@redhat.com>



On 15/03/2016 15:25, Michael S. Tsirkin wrote:
> Do you look at all warnings all your software prints?

Yes.  I also try to understand them, and if they seem useless I propose
a patch upstream.

> What if user uses some tool to build the command line?
> 
> consider mem-path - for years we printed a warning if
> it's not on hugetlbfs. It worked and users just ignored it.

That was a bad warning though.  There was no reason to warn.

It was also the smallest problem with the original hugetlbfs patches.

> So now Corey basically is prevented from sorting sanely
> because command line might not start with opt/

Can you explain?

Paolo

  parent reply	other threads:[~2016-03-15 14:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15 13:55 [Qemu-devel] [PATCH] vl.c: disallow command line fw cfg without opt/ Michael S. Tsirkin
2016-03-15 14:14 ` Paolo Bonzini
2016-03-15 14:25   ` Gerd Hoffmann
2016-03-15 14:27     ` Michael S. Tsirkin
2016-03-15 14:25   ` Michael S. Tsirkin
2016-03-15 14:46     ` Gerd Hoffmann
2016-03-15 14:54       ` Michael S. Tsirkin
2016-03-15 15:03         ` Gerd Hoffmann
2016-03-15 15:05           ` Michael S. Tsirkin
2016-03-15 14:54     ` Paolo Bonzini [this message]
2016-03-15 14:58       ` Michael S. Tsirkin
2016-03-17  1:31         ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E8222C.7090909@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=cminyard@mvista.com \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.