From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from a.ns.miles-group.at ([95.130.255.143] helo=radon.swed.at) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1afqrP-0005GV-MY for linux-mtd@lists.infradead.org; Tue, 15 Mar 2016 15:26:16 +0000 Subject: Re: Page migration issue with UBIFS To: "Kirill A. Shutemov" References: <56E8192B.5030008@nod.at> <20160315151727.GA16462@node.shutemov.name> Cc: linux-fsdevel , "linux-mtd@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Boris Brezillon , Maxime Ripard , David Gstir , Dave Chinner , Artem Bityutskiy , "Kirill A. Shutemov" , Alexander Kaplan From: Richard Weinberger Message-ID: <56E8297E.80708@nod.at> Date: Tue, 15 Mar 2016 16:25:50 +0100 MIME-Version: 1.0 In-Reply-To: <20160315151727.GA16462@node.shutemov.name> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Kirill, Am 15.03.2016 um 16:17 schrieb Kirill A. Shutemov: > On Tue, Mar 15, 2016 at 03:16:11PM +0100, Richard Weinberger wrote: >> Hi! >> >> We're facing this issue from 2014 on UBIFS: >> http://www.spinics.net/lists/linux-fsdevel/msg79941.html >> >> So sum up: >> UBIFS does not allow pages directly marked as dirty. It want's everyone to do it via UBIFS's >> ->wirte_end() and ->page_mkwirte() functions. >> This assumption *seems* to be violated by CMA which migrates pages. > > I don't thing the CMA/migration is the root cause. > > How did we end up with writable and dirty pte, but not having > ->page_mkwrite() called for the page? > > Or if ->page_mkwrite() was called, why the page is not dirty? Thanks for your quick response! I also don't think that the root cause is CMA or migration but it seems to be the messenger. Can you confirm that UBIFS's assumptions are valid? I'm trying to rule out possible issues and hunt down the root cause... Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: Page migration issue with UBIFS To: "Kirill A. Shutemov" References: <56E8192B.5030008@nod.at> <20160315151727.GA16462@node.shutemov.name> Cc: linux-fsdevel , "linux-mtd@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Boris Brezillon , Maxime Ripard , David Gstir , Dave Chinner , Artem Bityutskiy , "Kirill A. Shutemov" , Alexander Kaplan From: Richard Weinberger Message-ID: <56E8297E.80708@nod.at> Date: Tue, 15 Mar 2016 16:25:50 +0100 MIME-Version: 1.0 In-Reply-To: <20160315151727.GA16462@node.shutemov.name> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: Kirill, Am 15.03.2016 um 16:17 schrieb Kirill A. Shutemov: > On Tue, Mar 15, 2016 at 03:16:11PM +0100, Richard Weinberger wrote: >> Hi! >> >> We're facing this issue from 2014 on UBIFS: >> http://www.spinics.net/lists/linux-fsdevel/msg79941.html >> >> So sum up: >> UBIFS does not allow pages directly marked as dirty. It want's everyone to do it via UBIFS's >> ->wirte_end() and ->page_mkwirte() functions. >> This assumption *seems* to be violated by CMA which migrates pages. > > I don't thing the CMA/migration is the root cause. > > How did we end up with writable and dirty pte, but not having > ->page_mkwrite() called for the page? > > Or if ->page_mkwrite() was called, why the page is not dirty? Thanks for your quick response! I also don't think that the root cause is CMA or migration but it seems to be the messenger. Can you confirm that UBIFS's assumptions are valid? I'm trying to rule out possible issues and hunt down the root cause... Thanks, //richard -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org