All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 4/4] usb: Change power-on / scanning timeout handling
Date: Tue, 15 Mar 2016 17:00:07 +0100	[thread overview]
Message-ID: <56E83187.5010106@denx.de> (raw)
In-Reply-To: <56E82FC5.8080101@wwwdotorg.org>

Hi Stephen,

On 15.03.2016 16:52, Stephen Warren wrote:
> On 03/15/2016 07:16 AM, Stefan Roese wrote:
>> Hi Stephen,
>>
>> On 14.03.2016 18:51, Stephen Warren wrote:
>>> On 03/14/2016 04:18 AM, Stefan Roese wrote:
>>>> This patch changes the USB port scanning procedure and timeout
>>>> handling in the following ways:
>>>  >..
>>>
>>> Tested-by: Stephen Warren <swarren@nvidia.com>
>>>
>>> (including some tests with a 7-port (i.e. 2 nested 4-port) USB hub maxed
>>> out with devices).
>>
>> Thanks for doing those tests on your platform. I'm interested, how
>> big the time difference between stock U-Boot and the patched
>> version is though. Could you please post those numbers once for
>> reference, if its not too much trouble?
> 
> It looks like ~17s for v2016.01, and ~6s for u-boot/master from 
> yesterday plus these patches, with the following configuration:
> 
> Tegra124 (Jetson TK1) # usb tree
> USB device tree:
>    1  Hub (480 Mb/s, 0mA)
>       u-boot EHCI Host Controller
> 
>    1  Hub (480 Mb/s, 0mA)
>    |  u-boot EHCI Host Controller
>    |
>    +-2  Hub (480 Mb/s, 100mA)
>      |   USB2.0 Hub
>      |
>      +-3  Hub (480 Mb/s, 100mA)
>      | |   USB2.0 Hub
>      | |
>      | +-6  Mass Storage (480 Mb/s, 2mA)
>      | |    Sunplus Innovation Technology. USB to Serial-ATA bridge 
> FF980813AF0000000000005FF16BFF
>      | |
>      | +-7  Mass Storage (480 Mb/s, 100mA)
>      | |    Generic    Mass Storage Device 00000000000006
>      | |
>      | +-8  Human Interface (1.5 Mb/s, 70mA)
>      | |    LITEON Technology USB Multimedia Keyboard
>      | |
>      | +-9  Human Interface (1.5 Mb/s, 100mA)
>      |      Microsoft Microsoft IntelliMouse? Explore
>      |
>      +-4  Vendor specific (480 Mb/s, 250mA)
>      |    ASIX Elec. Corp. AX88x72A 000001
>      |
>      +-5  Mass Storage (480 Mb/s, 200mA)
>           SanDisk Extreme AA010114140242512567

Thanks.

I'm wondering why your configuration takes that much longer to
scan than mine (x86 platform). My USB configuration is not
that different:

=> time usb start
starting USB...
USB0:   USB EHCI 1.00
scanning bus 0 for devices... 9 USB Device(s) found

time: 1.815 seconds
=> usb tree
USB device tree:
  1  Hub (480 Mb/s, 0mA)
  |  u-boot EHCI Host Controller 
  |
  +-2  Hub (480 Mb/s, 0mA)
    |
    +-3  Hub (480 Mb/s, 100mA)
    | |
    | +-7  Hub (12 Mb/s, 100mA)
    |    
    +-4  Hub (480 Mb/s, 0mA)
    | |
    | +-8  Mass Storage (480 Mb/s, 200mA)
    | |    Kingston DataTraveler 2.0 50E549C688C4BE7189942766
    | |  
    | +-9  Mass Storage (480 Mb/s, 98mA)
    |      USBest Technology USB Mass Storage Device 09092207fbf0c4
    |    
    +-5  Mass Storage (480 Mb/s, 200mA)
    |    6989 Intenso Alu Line EE706F5E
    |  
    +-6  Mass Storage (480 Mb/s, 200mA)
         JetFlash Mass Storage Device 3281440601


And I'm down to less than 2 seconds scanning time. Perhaps
worth digging into at some point. But lets get this version
upstreamed first.

Thanks,
Stefan

  reply	other threads:[~2016-03-15 16:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14 10:18 [U-Boot] [PATCH v3 0/4] usb: Reduce USB scanning time Stefan Roese
2016-03-14 10:18 ` [U-Boot] [PATCH v3 1/4] usb: legacy_hub_port_reset(): Speedup hub reset handling Stefan Roese
2016-03-14 10:18 ` [U-Boot] [PATCH v3 2/4] usb: Remove 200 ms delay in usb_hub_port_connect_change() Stefan Roese
2016-03-14 17:06   ` Stephen Warren
2016-03-14 10:18 ` [U-Boot] [PATCH v3 3/4] usb: Don't reset the USB hub a 2nd time Stefan Roese
2016-03-14 10:18 ` [U-Boot] [PATCH v3 4/4] usb: Change power-on / scanning timeout handling Stefan Roese
2016-03-14 12:45   ` Hans de Goede
2016-03-14 13:19     ` Stefan Roese
2016-03-14 17:31   ` Stephen Warren
2016-03-14 19:47     ` Hans de Goede
2016-03-15  9:46     ` Stefan Roese
2016-03-15 15:42       ` Stephen Warren
2016-03-14 17:51   ` Stephen Warren
2016-03-15 13:16     ` Stefan Roese
2016-03-15 15:52       ` Stephen Warren
2016-03-15 16:00         ` Stefan Roese [this message]
2016-03-15 16:07           ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E83187.5010106@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.