From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcel Apfelbaum <marcel@redhat.com>, qemu-devel@nongnu.org
Cc: imammedo@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hw/acpi: fix GSI links UID
Date: Tue, 15 Mar 2016 18:27:56 +0100 [thread overview]
Message-ID: <56E8461C.6030306@redhat.com> (raw)
In-Reply-To: <1457869229-9989-1-git-send-email-marcel@redhat.com>
On 13/03/2016 12:40, Marcel Apfelbaum wrote:
> According to the ACPI spec, each UID must be unique.
> Use the irq number as UID for GSI links.
>
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
This causes a warning from acpi-test. The diff is
2720c2720
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x10) // _UID: Unique ID
2747c2747
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x11) // _UID: Unique ID
2774c2774
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x12) // _UID: Unique ID
2801c2801
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x13) // _UID: Unique ID
2828c2828
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x14) // _UID: Unique ID
2855c2855
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x15) // _UID: Unique ID
2882c2882
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x16) // _UID: Unique ID
2909c2909
< Name (_UID, Zero) // _UID: Unique ID
---
> Name (_UID, 0x17) // _UID: Unique ID
I think you should have updated tests/acpi-test-data.
Paolo
next prev parent reply other threads:[~2016-03-15 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-13 11:40 [Qemu-devel] [PATCH] hw/acpi: fix GSI links UID Marcel Apfelbaum
2016-03-14 9:43 ` Igor Mammedov
2016-03-15 17:27 ` Paolo Bonzini [this message]
2016-03-16 12:17 ` Marcel Apfelbaum
2016-03-16 14:03 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E8461C.6030306@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.