From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers
Date: Tue, 15 Mar 2016 18:44:56 +0100 [thread overview]
Message-ID: <56E84A18.7080803@redhat.com> (raw)
In-Reply-To: <CAFEAcA-dtRybf25vWFOoBWn9qyYsWRPkp69bPPz1KAtwaSws8g@mail.gmail.com>
On 15/03/2016 18:34, Peter Maydell wrote:
>> > Since I have your attention, what about getting rid of fprintf-fn.h and
>> > moving it into qemu/osdep.h?
> Not a lot very osdep-ish about it... If you're going to put it anywhere
> then typedefs.h seems more appropriate.
Well, osdep.h is the new qemu-common.h. At least it doesn't include
other^Wtoo many other QEMU header files, but it does have a lot of
prototypes that are even more out of place than fprintf_function.
On the other hand, there are few enough headers that use fprintf-fn.h
that it's feasible to just push it down from qemu-common.h.
Paolo
> (It's in its own file at the moment as part of a previous idea of
> cleaning up qemu-common.h by splitting it into separate parts where
> necessary so that only the needed parts could be included by the
> code that wanted them.)
next prev parent reply other threads:[~2016-03-15 17:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 15:03 [Qemu-devel] [PATCH 00/15] Clean up around osdep.h and qemu-common.h Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 01/15] include/qemu/osdep.h: Don't include qapi/error.h Markus Armbruster
2016-03-15 16:04 ` Paolo Bonzini
2016-03-15 16:26 ` Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 02/15] Use scripts/clean-includes to drop redundant qemu/typedefs.h Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 03/15] include/config.h: Unused, remove Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 04/15] Clean up includes some more Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 05/15] fw_cfg: Split fw_cfg_keys.h off fw_cfg.h Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 06/15] include/qemu/iov.h: Don't include qemu-common.h Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 07/15] include/hw/hw.h: " Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 08/15] hw/pci/pci.h: " Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 09/15] Move HOST_LONG_BITS from qemu-common.h to qemu/osdep.h Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 10/15] Move QEMU_ALIGN_*() " Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 11/15] Move ParallelIOArg from qemu-common.h to sysemu/char.h Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 12/15] isa: Move DMA_transfer_handler from qemu-common.h to hw/isa/isa.h Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 13/15] include/crypto: Include qapi-types.h instead of qemu-common.h Markus Armbruster
2016-03-15 15:51 ` Daniel P. Berrange
2016-03-15 16:24 ` Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers Markus Armbruster
2016-03-15 15:54 ` Daniel P. Berrange
2016-03-15 16:35 ` Markus Armbruster
2016-03-15 15:55 ` Paolo Bonzini
2016-03-15 16:31 ` Markus Armbruster
2016-03-15 17:25 ` Paolo Bonzini
2016-03-15 17:34 ` Peter Maydell
2016-03-15 17:44 ` Paolo Bonzini [this message]
2016-03-15 17:53 ` Peter Maydell
2016-03-15 19:03 ` Markus Armbruster
2016-03-15 15:03 ` [Qemu-devel] [PATCH 15/15] Drop superfluous qemu-common.h inclusions Markus Armbruster
2016-03-15 15:30 ` [Qemu-devel] [PATCH 00/15] Clean up around osdep.h and qemu-common.h Paolo Bonzini
2016-03-18 8:47 ` Markus Armbruster
2016-03-18 9:05 ` Peter Maydell
2016-03-18 9:55 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E84A18.7080803@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.