From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH 5/5] tmem: allow tmem to be disabled with Kconfig Date: Tue, 15 Mar 2016 14:04:31 -0500 Message-ID: <56E85CBF.7000600@cardoe.com> References: <1457987365-866-1-git-send-email-cardoe@cardoe.com> <1457987365-866-6-git-send-email-cardoe@cardoe.com> <56E7D67602000078000DC5E9@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2180021933774733862==" Return-path: In-Reply-To: <56E7D67602000078000DC5E9@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Andrew Cooper , Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2180021933774733862== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5EWc6xjbCt7389KlgEexPWdQSO6oowiLp" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5EWc6xjbCt7389KlgEexPWdQSO6oowiLp Content-Type: multipart/mixed; boundary="RVkT18325CT8kwlittEo0ECqHW1CRU1iW" From: Doug Goldstein To: Jan Beulich Cc: Andrew Cooper , xen-devel@lists.xen.org, Konrad Rzeszutek Wilk , Keir Fraser Message-ID: <56E85CBF.7000600@cardoe.com> Subject: Re: [PATCH 5/5] tmem: allow tmem to be disabled with Kconfig References: <1457987365-866-1-git-send-email-cardoe@cardoe.com> <1457987365-866-6-git-send-email-cardoe@cardoe.com> <56E7D67602000078000DC5E9@prv-mh.provo.novell.com> In-Reply-To: <56E7D67602000078000DC5E9@prv-mh.provo.novell.com> --RVkT18325CT8kwlittEo0ECqHW1CRU1iW Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/15/16 3:31 AM, Jan Beulich wrote: >>>> On 14.03.16 at 21:29, wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -5311,6 +5311,10 @@ typedef unsigned long hvm_hypercall_t( >> #define compat_grant_table_op hvm_grant_table_op_compat32 >> #define do_arch_1 paging_domctl_continuation >> =20 >> +#ifndef CONFIG_TMEM >> +#define do_tmem_op do_ni_hypercall >> +#endif >=20 > This being repeated in 3 places, wouldn't be better to put this in, > say, xen/hypercall.h, next to the function declaration? >=20 Actually I tried this and it doesn't compile because that header isn't included. Including that header into the relevant files (entry.S) doesn't work either. Got a different suggestion? --=20 Doug Goldstein --RVkT18325CT8kwlittEo0ECqHW1CRU1iW-- --5EWc6xjbCt7389KlgEexPWdQSO6oowiLp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJW6FzCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvU1MgP/3zAgeipczoHteHG9QSdlJFX y0Qry7C2bncuYfUvJE/pvDYJvL+IofrkJL2a+mBAfu/p7PWXoFVQv656v2hs5LmL PftWPrugkoTRNwO7SCvVnhd1t4SnWJFBkREAz2srKOn4Me+kumowl4eD3Hpt608q awjKskDbEfyLi4/w2LPBVchJdLqOc1JLEgoF8zlinNM521b7NeqtxzNG1H7elJCs he5OyUgVLeIoeiF+T3eN9Tx5N2Sn52YlS1aly15j6C+K4Arrdaf3ZrSaEwQiuTE2 LQdUtHHLZRYTEr9bU2gY66YMUI5ZFRpA0QmA56Hg4H3tC/6qV7yu5KXFdaKMVYuM vgdjLjLAoKIujPTXmYsb+byiG6GnkCLRLe1F6ASvhesTp0kgWL9g0PgBX6MHSuD3 E/f39q+HX3TPf0/VV/5EZk6WJntJDWY3sRz1ANT4G59XSre3TaNFze7S0cwi6+zH 0StZ7SqxCNMHjMlIF3KmQimtagljj1ot0KT7Z6GlPcjKgCNVD+cAsj3hy2rx+Wxx h8a8gzOGORZcpuYgWNoVSgPUS4vbggKf+p1TockZFtS5YPrAagBZa+aeePKJEBMY K1S15UPh7AMKOlHVTZ/rWFU96p+oy6CTyu2Ee17idxL2JgTYcF6iuEiHnjABHSwW Bo2n/rZ/HVBNOfhSmroT =YKsE -----END PGP SIGNATURE----- --5EWc6xjbCt7389KlgEexPWdQSO6oowiLp-- --===============2180021933774733862== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============2180021933774733862==--