All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: Aaron Luft <aluft@lifesize.com>
Cc: "grub-devel@gnu.org" <grub-devel@gnu.org>
Subject: Re: 2.02-beta3 remove attempt to free stack space and initialize variable before possible use
Date: Tue, 15 Mar 2016 22:18:27 +0300	[thread overview]
Message-ID: <56E86003.7000002@gmail.com> (raw)
In-Reply-To: <90AB4A90-8A7B-429C-9EA7-B6E337A492EA@lifesize.com>

15.03.2016 00:21, Aaron Luft пишет:
> 
>> On Mar 14, 2016, at 1:35 PM, Andrei Borzenkov <arvidjaar@gmail.com> wrote:
>> Yes, this is one correct. Please resend as attached patch generated by
>> "git format-patch" with suitable commit message. Do not expand tabs when
>> editing.
>>
> Ok, attaching the patch to this mail.
> 

I committed the iso9660 patch adding commit message with some explanation.

>>
>> Well ... it cannot really reach code where mdnobj is used if
>> grub_zfs_getmdnobj() fails but static analyzer may not know it.
>>
>> How do you compile it? I cannot reproduce it using gcc 5.3.1 nor did it
>> fail previously. Do you use non-standard compiler flags?
> 
> Yes, non-standard command line.
> I found an extra -Wall that the standard build doesn't have.
> 

We use -Wall always. The problem is apparently caused by using LTO.
Could you upload somewhere full log of configure && make with this error?


      reply	other threads:[~2016-03-15 19:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14 14:37 2.02-beta3 remove attempt to free stack space and initialize variable before possible use Aaron Luft
2016-03-14 17:35 ` Andrei Borzenkov
2016-03-14 21:21   ` Aaron Luft
2016-03-15 19:18     ` Andrei Borzenkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E86003.7000002@gmail.com \
    --to=arvidjaar@gmail.com \
    --cc=aluft@lifesize.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.