From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] docs: update FLASK cmd line instructions Date: Tue, 15 Mar 2016 15:40:19 -0500 Message-ID: <56E87333.9080402@cardoe.com> References: <1458002259-22081-1-git-send-email-cardoe@cardoe.com> <20160315202427.GI26955@char.us.oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7366424546225509952==" Return-path: In-Reply-To: <20160315202427.GI26955@char.us.oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Konrad Rzeszutek Wilk Cc: Keir Fraser , Ian Jackson , Tim Deegan , xen-devel@lists.xen.org, Jan Beulich , Daniel De Graaf List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============7366424546225509952== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="F1M8pOXWKQIWEl9lBPrLrToNeWp2mU98T" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --F1M8pOXWKQIWEl9lBPrLrToNeWp2mU98T Content-Type: multipart/mixed; boundary="B98krHeEwXXbeMu9Xf3NxlrQ7HCjw04ug" From: Doug Goldstein To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xen.org, Ian Jackson , Jan Beulich , Keir Fraser , Tim Deegan , Daniel De Graaf Message-ID: <56E87333.9080402@cardoe.com> Subject: Re: [PATCH] docs: update FLASK cmd line instructions References: <1458002259-22081-1-git-send-email-cardoe@cardoe.com> <20160315202427.GI26955@char.us.oracle.com> In-Reply-To: <20160315202427.GI26955@char.us.oracle.com> --B98krHeEwXXbeMu9Xf3NxlrQ7HCjw04ug Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/15/16 3:24 PM, Konrad Rzeszutek Wilk wrote: > On Mon, Mar 14, 2016 at 07:37:39PM -0500, Doug Goldstein wrote: >> The command line instructions for FLASK include a note on how to compi= le >> Xen with FLASK but the note was out of date after the change to Kconfi= g. >> >> Signed-off-by: Doug Goldstein >> --- >> CC: Ian Jackson >> CC: Jan Beulich >> CC: Keir Fraser >> CC: Tim Deegan >> CC: Konrad Rzeszutek Wilk >> CC: Daniel De Graaf >> >> Not sure if you want backticks around `make -C menuconfig`. I also fig= ured >> we should route people towards menuconfig by default. The committer of= >> this patch is welcome to change the wording or style in anyway they se= e >> fit. >> >> --- >> docs/misc/xen-command-line.markdown | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-comma= nd-line.markdown >> index ca77e3b..949e210 100644 >> --- a/docs/misc/xen-command-line.markdown >> +++ b/docs/misc/xen-command-line.markdown >> @@ -665,8 +665,8 @@ to use the default. >> > Default: `permissive` >> =20 >> Specify how the FLASK security server should be configured. This opt= ion is only >> -available if the hypervisor was compiled with XSM support (which can = be enabled >> -by setting XSM\_ENABLE =3D y in .config). >> +available if the hypervisor was compiled with FLASK support. This ca= n be >> +enabled by running make -C xen menuconfig and enabling XSM and FLASK.= >=20 > Would it be better said: >=20 > .. "and enabling Common Features|Xen Security Module support (FLux Adva= nced Security > Kernel support gets enabled automatically)." > ? My response falls in the bucket of a tristate boolean. It depends on how you want to document these values. By the pretty strings or the searchable names. And then making sure all the doc places are consistent with that. --=20 Doug Goldstein --B98krHeEwXXbeMu9Xf3NxlrQ7HCjw04ug-- --F1M8pOXWKQIWEl9lBPrLrToNeWp2mU98T Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJW6HM4XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUOckP+QGom1xBntYMUhLFYqoJov5z GGoTb8hButm16CYfjuz2afIlTKM53Wm84g9decJO8OnO0O+2VY7qxqgUH+UCOBcd rOb5qorUPPGEVJIMPtfYknDxtClehWM86KvUHvaqmZ2FY/nK5pxxqC1FnR3kKz7f rtHtB/yRFWxyu4ucAKkMDSk9rF65VFb9sdVAB5qJE1JlVNf0jKJ437UHBQuAy5Q9 7LvXJUyMwS6GTyJjKJgzF+IlVcv72rJ3M3MtlXuTAE46k95EfcQJwPrtMw4YZAOB 6ilFGX3nIEAehFqPDK8AFRMWSe3ud2w2xA5OMZAeZSspiXIScWlXmFOR4wPidRVq RN2XIo6fjKDo5UI1jGPenrD1NSZiEk3D81RkdZBnS8UzfjNHP0QVq9NqCEkWV+Rj WWSa6BO5QBFfbhOc9Ad9tAXIjMHyXTa2OyMu1QvYXn5AlNuBAvq3Ujx9EAG9Tl/f hzKKz5VW/FXfmtqxI9YQH+ojO+NgQDWyKt7yvbYlwxj8MwtfzEEbJsZcQolarGOD HvdhWiM5THx6WmuhV7QV+anmjEFotK5ae4wk1hywu4v6FyqpZwWl6vpbtoDiVzj1 fODJTdjqcTq2mFhQ6ltlhkmyCih3sKZbt8XYvI0VPsO9fB+2HMqeWbFyQoEfLSUA AAiLqwVBHYZXINwhCjI5 =P4el -----END PGP SIGNATURE----- --F1M8pOXWKQIWEl9lBPrLrToNeWp2mU98T-- --===============7366424546225509952== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============7366424546225509952==--